Commit f17b558d authored by Dan Williams's avatar Dan Williams
Browse files

cxl/pmem: Refactor nvdimm device registration, delete the workqueue 



The three objects 'struct cxl_nvdimm_bridge', 'struct cxl_nvdimm', and
'struct cxl_pmem_region' manage CXL persistent memory resources. The
bridge represents base platform resources, the nvdimm represents one or
more endpoints, and the region is a collection of nvdimms that
contribute to an assembled address range.

Their relationship is such that a region is torn down if any component
endpoints are removed. All regions and endpoints are torn down if the
foundational bridge device goes down.

A workqueue was deployed to manage these interdependencies, but it is
difficult to reason about, and fragile. A recent attempt to take the CXL
root device lock in the cxl_mem driver was reported by lockdep as
colliding with the flush_work() in the cxl_pmem flows.

Instead of the workqueue, arrange for all pmem/nvdimm devices to be torn
down immediately and hierarchically. A similar change is made to both
the 'cxl_nvdimm' and 'cxl_pmem_region' objects. For bisect-ability both
changes are made in the same patch which unfortunately makes the patch
bigger than desired.

Arrange for cxl_memdev and cxl_region to register a cxl_nvdimm and
cxl_pmem_region as a devres release action of the bridge device.
Additionally, include a devres release action of the cxl_memdev or
cxl_region device that triggers the bridge's release action if an endpoint
exits before the bridge. I.e. this allows either unplugging the bridge,
or unplugging and endpoint to result in the same cleanup actions.

To keep the patch smaller the cleanup of the now defunct workqueue
infrastructure is saved for a follow-on patch.

Tested-by: default avatarRobert Richter <rrichter@amd.com>
Link: https://lore.kernel.org/r/166993041773.1882361.16444301376147207609.stgit@dwillia2-xfh.jf.intel.com


Reviewed-by: default avatarJonathan Cameron <Jonathan.Cameron@huawei.com>
Signed-off-by: default avatarDan Williams <dan.j.williams@intel.com>
parent 16d53cb0

drivers/cxl/core/pmem.c

+67 −11
Original line number Diff line number Diff line
@@ -219,7 +219,8 @@ EXPORT_SYMBOL_NS_GPL(to_cxl_nvdimm, CXL); 


static struct lock_class_key cxl_nvdimm_key;



static struct cxl_nvdimm *cxl_nvdimm_alloc(struct cxl_memdev *cxlmd)

static struct cxl_nvdimm *cxl_nvdimm_alloc(struct cxl_nvdimm_bridge *cxl_nvb,

					   struct cxl_memdev *cxlmd)

{

	struct cxl_nvdimm *cxl_nvd;

	struct device *dev;
@@ -230,6 +231,7 @@ static struct cxl_nvdimm *cxl_nvdimm_alloc(struct cxl_memdev *cxlmd) 


	dev = &cxl_nvd->dev;

	cxl_nvd->cxlmd = cxlmd;

	cxlmd->cxl_nvd = cxl_nvd;

	device_initialize(dev);

	lockdep_set_class(&dev->mutex, &cxl_nvdimm_key);

	device_set_pm_not_required(dev);
@@ -240,27 +242,60 @@ static struct cxl_nvdimm *cxl_nvdimm_alloc(struct cxl_memdev *cxlmd) 
	return cxl_nvd;

}



static void cxl_nvd_unregister(void *dev)

static void cxl_nvd_unregister(void *_cxl_nvd)

{

	device_unregister(dev);

	struct cxl_nvdimm *cxl_nvd = _cxl_nvd;

	struct cxl_memdev *cxlmd = cxl_nvd->cxlmd;

	struct cxl_nvdimm_bridge *cxl_nvb = cxlmd->cxl_nvb;



	/*

	 * Either the bridge is in ->remove() context under the device_lock(),

	 * or cxlmd_release_nvdimm() is cancelling the bridge's release action

	 * for @cxl_nvd and doing it itself (while manually holding the bridge

	 * lock).

	 */

	device_lock_assert(&cxl_nvb->dev);

	cxl_nvd->cxlmd = NULL;

	cxlmd->cxl_nvd = NULL;

	device_unregister(&cxl_nvd->dev);

}



static void cxlmd_release_nvdimm(void *_cxlmd)

{

	struct cxl_memdev *cxlmd = _cxlmd;

	struct cxl_nvdimm_bridge *cxl_nvb = cxlmd->cxl_nvb;



	device_lock(&cxl_nvb->dev);

	if (cxlmd->cxl_nvd)

		devm_release_action(&cxl_nvb->dev, cxl_nvd_unregister,

				    cxlmd->cxl_nvd);

	device_unlock(&cxl_nvb->dev);

	put_device(&cxl_nvb->dev);

}



/**

 * devm_cxl_add_nvdimm() - add a bridge between a cxl_memdev and an nvdimm

 * @host: same host as @cxlmd

 * @cxlmd: cxl_memdev instance that will perform LIBNVDIMM operations

 *

 * Return: 0 on success negative error code on failure.

 */

int devm_cxl_add_nvdimm(struct device *host, struct cxl_memdev *cxlmd)

int devm_cxl_add_nvdimm(struct cxl_memdev *cxlmd)

{

	struct cxl_nvdimm_bridge *cxl_nvb;

	struct cxl_nvdimm *cxl_nvd;

	struct device *dev;

	int rc;



	cxl_nvd = cxl_nvdimm_alloc(cxlmd);

	if (IS_ERR(cxl_nvd))

		return PTR_ERR(cxl_nvd);

	cxl_nvb = cxl_find_nvdimm_bridge(&cxlmd->dev);

	if (!cxl_nvb)

		return -ENODEV;



	cxl_nvd = cxl_nvdimm_alloc(cxl_nvb, cxlmd);

	if (IS_ERR(cxl_nvd)) {

		rc = PTR_ERR(cxl_nvd);

		goto err_alloc;

	}

	cxlmd->cxl_nvb = cxl_nvb;



	dev = &cxl_nvd->dev;

	rc = dev_set_name(dev, "pmem%d", cxlmd->id);
@@ -271,13 +306,34 @@ int devm_cxl_add_nvdimm(struct device *host, struct cxl_memdev *cxlmd) 
	if (rc)

		goto err;



	dev_dbg(host, "%s: register %s\n", dev_name(dev->parent),

		dev_name(dev));

	dev_dbg(&cxlmd->dev, "register %s\n", dev_name(dev));



	/*

	 * The two actions below arrange for @cxl_nvd to be deleted when either

	 * the top-level PMEM bridge goes down, or the endpoint device goes

	 * through ->remove().

	 */

	device_lock(&cxl_nvb->dev);

	if (cxl_nvb->dev.driver)

		rc = devm_add_action_or_reset(&cxl_nvb->dev, cxl_nvd_unregister,

					      cxl_nvd);

	else

		rc = -ENXIO;

	device_unlock(&cxl_nvb->dev);



	if (rc)

		goto err_alloc;



	return devm_add_action_or_reset(host, cxl_nvd_unregister, dev);

	/* @cxlmd carries a reference on @cxl_nvb until cxlmd_release_nvdimm */

	return devm_add_action_or_reset(&cxlmd->dev, cxlmd_release_nvdimm, cxlmd);



err:

	put_device(dev);

err_alloc:

	cxlmd->cxl_nvb = NULL;

	cxlmd->cxl_nvd = NULL;

	put_device(&cxl_nvb->dev);



	return rc;

}

EXPORT_SYMBOL_NS_GPL(devm_cxl_add_nvdimm, CXL);

drivers/cxl/core/region.c

+61 −3
Original line number Diff line number Diff line
@@ -1812,6 +1812,7 @@ static struct lock_class_key cxl_pmem_region_key; 
static struct cxl_pmem_region *cxl_pmem_region_alloc(struct cxl_region *cxlr)

{

	struct cxl_region_params *p = &cxlr->params;

	struct cxl_nvdimm_bridge *cxl_nvb;

	struct cxl_pmem_region *cxlr_pmem;

	struct device *dev;

	int i;
@@ -1839,6 +1840,18 @@ static struct cxl_pmem_region *cxl_pmem_region_alloc(struct cxl_region *cxlr) 
		struct cxl_memdev *cxlmd = cxled_to_memdev(cxled);

		struct cxl_pmem_region_mapping *m = &cxlr_pmem->mapping[i];



		/*

		 * Regions never span CXL root devices, so by definition the

		 * bridge for one device is the same for all.

		 */

		if (i == 0) {

			cxl_nvb = cxl_find_nvdimm_bridge(&cxlmd->dev);

			if (!cxl_nvb) {

				cxlr_pmem = ERR_PTR(-ENODEV);

				goto out;

			}

			cxlr->cxl_nvb = cxl_nvb;

		}

		m->cxlmd = cxlmd;

		get_device(&cxlmd->dev);

		m->start = cxled->dpa_res->start;
@@ -1848,6 +1861,7 @@ static struct cxl_pmem_region *cxl_pmem_region_alloc(struct cxl_region *cxlr) 


	dev = &cxlr_pmem->dev;

	cxlr_pmem->cxlr = cxlr;

	cxlr->cxlr_pmem = cxlr_pmem;

	device_initialize(dev);

	lockdep_set_class(&dev->mutex, &cxl_pmem_region_key);

	device_set_pm_not_required(dev);
@@ -1860,9 +1874,36 @@ static struct cxl_pmem_region *cxl_pmem_region_alloc(struct cxl_region *cxlr) 
	return cxlr_pmem;

}



static void cxlr_pmem_unregister(void *dev)

static void cxlr_pmem_unregister(void *_cxlr_pmem)

{

	device_unregister(dev);

	struct cxl_pmem_region *cxlr_pmem = _cxlr_pmem;

	struct cxl_region *cxlr = cxlr_pmem->cxlr;

	struct cxl_nvdimm_bridge *cxl_nvb = cxlr->cxl_nvb;



	/*

	 * Either the bridge is in ->remove() context under the device_lock(),

	 * or cxlr_release_nvdimm() is cancelling the bridge's release action

	 * for @cxlr_pmem and doing it itself (while manually holding the bridge

	 * lock).

	 */

	device_lock_assert(&cxl_nvb->dev);

	cxlr->cxlr_pmem = NULL;

	cxlr_pmem->cxlr = NULL;

	device_unregister(&cxlr_pmem->dev);

}



static void cxlr_release_nvdimm(void *_cxlr)

{

	struct cxl_region *cxlr = _cxlr;

	struct cxl_nvdimm_bridge *cxl_nvb = cxlr->cxl_nvb;



	device_lock(&cxl_nvb->dev);

	if (cxlr->cxlr_pmem)

		devm_release_action(&cxl_nvb->dev, cxlr_pmem_unregister,

				    cxlr->cxlr_pmem);

	device_unlock(&cxl_nvb->dev);

	cxlr->cxl_nvb = NULL;

	put_device(&cxl_nvb->dev);

}



/**
@@ -1874,12 +1915,14 @@ static void cxlr_pmem_unregister(void *dev) 
static int devm_cxl_add_pmem_region(struct cxl_region *cxlr)

{

	struct cxl_pmem_region *cxlr_pmem;

	struct cxl_nvdimm_bridge *cxl_nvb;

	struct device *dev;

	int rc;



	cxlr_pmem = cxl_pmem_region_alloc(cxlr);

	if (IS_ERR(cxlr_pmem))

		return PTR_ERR(cxlr_pmem);

	cxl_nvb = cxlr->cxl_nvb;



	dev = &cxlr_pmem->dev;

	rc = dev_set_name(dev, "pmem_region%d", cxlr->id);
@@ -1893,10 +1936,25 @@ static int devm_cxl_add_pmem_region(struct cxl_region *cxlr) 
	dev_dbg(&cxlr->dev, "%s: register %s\n", dev_name(dev->parent),

		dev_name(dev));



	return devm_add_action_or_reset(&cxlr->dev, cxlr_pmem_unregister, dev);

	device_lock(&cxl_nvb->dev);

	if (cxl_nvb->dev.driver)

		rc = devm_add_action_or_reset(&cxl_nvb->dev,

					      cxlr_pmem_unregister, cxlr_pmem);

	else

		rc = -ENXIO;

	device_unlock(&cxl_nvb->dev);



	if (rc)

		goto err_bridge;



	/* @cxlr carries a reference on @cxl_nvb until cxlr_release_nvdimm */

	return devm_add_action_or_reset(&cxlr->dev, cxlr_release_nvdimm, cxlr);



err:

	put_device(dev);

err_bridge:

	put_device(&cxl_nvb->dev);

	cxlr->cxl_nvb = NULL;

	return rc;

}

drivers/cxl/cxl.h

+5 −2
Original line number Diff line number Diff line
@@ -386,6 +386,8 @@ struct cxl_region_params { 
 * @id: This region's id. Id is globally unique across all regions

 * @mode: Endpoint decoder allocation / access mode

 * @type: Endpoint decoder target type

 * @cxl_nvb: nvdimm bridge for coordinating @cxlr_pmem setup / shutdown

 * @cxlr_pmem: (for pmem regions) cached copy of the nvdimm bridge

 * @params: active + config params for the region

 */

struct cxl_region {
@@ -393,6 +395,8 @@ struct cxl_region { 
	int id;

	enum cxl_decoder_mode mode;

	enum cxl_decoder_type type;

	struct cxl_nvdimm_bridge *cxl_nvb;

	struct cxl_pmem_region *cxlr_pmem;

	struct cxl_region_params params;

};
@@ -438,7 +442,6 @@ struct cxl_pmem_region { 
	struct device dev;

	struct cxl_region *cxlr;

	struct nd_region *nd_region;

	struct cxl_nvdimm_bridge *bridge;

	struct range hpa_range;

	int nr_mappings;

	struct cxl_pmem_region_mapping mapping[];
@@ -637,7 +640,7 @@ struct cxl_nvdimm_bridge *devm_cxl_add_nvdimm_bridge(struct device *host, 
struct cxl_nvdimm *to_cxl_nvdimm(struct device *dev);

bool is_cxl_nvdimm(struct device *dev);

bool is_cxl_nvdimm_bridge(struct device *dev);

int devm_cxl_add_nvdimm(struct device *host, struct cxl_memdev *cxlmd);

int devm_cxl_add_nvdimm(struct cxl_memdev *cxlmd);

struct cxl_nvdimm_bridge *cxl_find_nvdimm_bridge(struct device *dev);



#ifdef CONFIG_CXL_REGION

drivers/cxl/cxlmem.h

+4 −0
Original line number Diff line number Diff line
@@ -35,6 +35,8 @@ 
 * @cdev: char dev core object for ioctl operations

 * @cxlds: The device state backing this device

 * @detach_work: active memdev lost a port in its ancestry

 * @cxl_nvb: coordinate removal of @cxl_nvd if present

 * @cxl_nvd: optional bridge to an nvdimm if the device supports pmem

 * @id: id number of this memdev instance.

 */

struct cxl_memdev {
@@ -42,6 +44,8 @@ struct cxl_memdev { 
	struct cdev cdev;

	struct cxl_dev_state *cxlds;

	struct work_struct detach_work;

	struct cxl_nvdimm_bridge *cxl_nvb;

	struct cxl_nvdimm *cxl_nvd;

	int id;

};

drivers/cxl/mem.c

+9 −0
Original line number Diff line number Diff line
@@ -48,6 +48,7 @@ static int cxl_mem_dpa_show(struct seq_file *file, void *data) 
static int cxl_mem_probe(struct device *dev)

{

	struct cxl_memdev *cxlmd = to_cxl_memdev(dev);

	struct cxl_dev_state *cxlds = cxlmd->cxlds;

	struct cxl_port *parent_port;

	struct cxl_dport *dport;

	struct dentry *dentry;
@@ -95,6 +96,14 @@ static int cxl_mem_probe(struct device *dev) 
	if (rc)

		return rc;



	if (resource_size(&cxlds->pmem_res) && IS_ENABLED(CONFIG_CXL_PMEM)) {

		rc = devm_cxl_add_nvdimm(cxlmd);

		if (rc == -ENODEV)

			dev_info(dev, "PMEM disabled by platform\n");

		else

			return rc;

	}



	/*

	 * The kernel may be operating out of CXL memory on this device,

	 * there is no spec defined way to determine whether this device