Commit f13aada0 authored by Maurizio Lombardi's avatar Maurizio Lombardi Committed by Jialin Zhang
Browse files

nvmet-tcp: fix unhandled tcp states in nvmet_tcp_state_change() 

stable inclusion
from stable-v5.10.144
commit c598e2704c3b315078c07d97cec02573bfe1fa7e
category: bugfix
bugzilla: https://gitee.com/openeuler/kernel/issues/I6D0V7

Reference: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?id=c598e2704c3b315078c07d97cec02573bfe1fa7e



--------------------------------

[ Upstream commit 478814a5 ]

TCP_FIN_WAIT2 and TCP_LAST_ACK were not handled, the connection is closing
so we can ignore them and avoid printing the "unhandled state"
warning message.

[ 1298.852386] nvmet_tcp: queue 2 unhandled state 5
[ 1298.879112] nvmet_tcp: queue 7 unhandled state 5
[ 1298.884253] nvmet_tcp: queue 8 unhandled state 5
[ 1298.889475] nvmet_tcp: queue 9 unhandled state 5

v2: Do not call nvmet_tcp_schedule_release_queue(), just ignore
the fin_wait2 and last_ack states.

Signed-off-by: default avatarMaurizio Lombardi <mlombard@redhat.com>
Reviewed-by: default avatarSagi Grimberg <sagi@grimberg.me>
Reviewed-by: default avatarChaitanya Kulkarni <kch@nvidia.com>
Signed-off-by: default avatarChristoph Hellwig <hch@lst.de>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
Signed-off-by: default avatarJialin Zhang <zhangjialin11@huawei.com>
Reviewed-by: default avatarZheng Zengkai <zhengzengkai@huawei.com>
parent 477fffcb

drivers/nvme/target/tcp.c

+3 −0
Original line number Diff line number Diff line
@@ -1471,6 +1471,9 @@ static void nvmet_tcp_state_change(struct sock *sk) 
		goto done;



	switch (sk->sk_state) {

	case TCP_FIN_WAIT2:

	case TCP_LAST_ACK:

		break;

	case TCP_FIN_WAIT1:

	case TCP_CLOSE_WAIT:

	case TCP_CLOSE: