Commit f10fe8f8 authored by José Roberto de Souza's avatar José Roberto de Souza
Browse files

Revert "drm/i915/tgl/psr: Fix glitches when doing frontbuffer modifications" 



This reverts commit 71c1a499.

The proper fix is Wa_14013723622, so now we can revert this WA and
get back some power savings.

Cc: Gwan-gyeong Mun <gwan-gyeong.mun@intel.com>
Signed-off-by: default avatarJosé Roberto de Souza <jose.souza@intel.com>
Reviewed-by: default avatarGwan-gyeong Mun <gwan-gyeong.mun@intel.com>
Tested-by: default avatarGwan-gyeong Mun <gwan-gyeong.mun@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20210408204917.254272-2-jose.souza@intel.com
parent 41c70d2b

drivers/gpu/drm/i915/display/intel_psr.c

+1 −15
Original line number Diff line number Diff line
@@ -1167,21 +1167,7 @@ static void psr_force_hw_tracking_exit(struct intel_dp *intel_dp) 
{

	struct drm_i915_private *dev_priv = dp_to_i915(intel_dp);



	if (IS_TIGERLAKE(dev_priv))

		/*

		 * Writes to CURSURFLIVE in TGL are causing IOMMU errors and

		 * visual glitches that are often reproduced when executing

		 * CPU intensive workloads while a eDP 4K panel is attached.

		 *

		 * Manually exiting PSR causes the frontbuffer to be updated

		 * without glitches and the IOMMU errors are also gone but

		 * this comes at the cost of less time with PSR active.

		 *

		 * So using this workaround until this issue is root caused

		 * and a better fix is found.

		 */

		intel_psr_exit(intel_dp);

	else if (DISPLAY_VER(dev_priv) >= 9)

	if (DISPLAY_VER(dev_priv) >= 9)

		/*

		 * Display WA #0884: skl+

		 * This documented WA for bxt can be safely applied