Commit f0e96e2e authored by Uwe Kleine-König's avatar Uwe Kleine-König Committed by Thierry Reding
Browse files

pwm: pca9685: Don't check the return code of pwmchip_remove() 



pwmchip_remove() returns always 0. Don't use the value to make it
possible to eventually change the function to return void. Also the
driver core ignores the return value of pca9685_pwm_remove()
and considers the device removed anyhow. So returning early results
in a resource leak.

Signed-off-by: default avatarUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: default avatarThierry Reding <thierry.reding@gmail.com>
parent faaa2222

drivers/pwm/pwm-pca9685.c

+1 −4
Original line number Diff line number Diff line
@@ -601,11 +601,8 @@ static int pca9685_pwm_probe(struct i2c_client *client, 
static int pca9685_pwm_remove(struct i2c_client *client)

{

	struct pca9685 *pca = i2c_get_clientdata(client);

	int ret;



	ret = pwmchip_remove(&pca->chip);

	if (ret)

		return ret;

	pwmchip_remove(&pca->chip);



	if (!pm_runtime_enabled(&client->dev)) {

		/* Put chip in sleep state if runtime PM is disabled */