Commit f0d75197 authored by Jakub Kicinski's avatar Jakub Kicinski
Browse files

eth: ixgbe: fix the wake condition 



Flip the netif_carrier_ok() condition in queue wake logic.
When I moved it to inside __netif_txq_completed_wake()
I missed negating it.

This made the condition ineffective and could probably
lead to crashes.

Fixes: 301f227f ("net: piggy back on the memory barrier in bql when waking queues")
Reviewed-by: default avatarTony Nguyen <anthony.l.nguyen@intel.com>
Link: https://lore.kernel.org/r/20230607010826.960226-2-kuba@kernel.org


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 649c3fed

drivers/net/ethernet/intel/ixgbe/ixgbe_main.c

+1 −1
Original line number Diff line number Diff line
@@ -1256,7 +1256,7 @@ static bool ixgbe_clean_tx_irq(struct ixgbe_q_vector *q_vector, 
	if (!__netif_txq_completed_wake(txq, total_packets, total_bytes,

					ixgbe_desc_unused(tx_ring),

					TX_WAKE_THRESHOLD,

					netif_carrier_ok(tx_ring->netdev) &&

					!netif_carrier_ok(tx_ring->netdev) ||

					test_bit(__IXGBE_DOWN, &adapter->state)))

		++tx_ring->tx_stats.restart_queue;