Commit f0ce5178 authored by Daniele Ceraolo Spurio's avatar Daniele Ceraolo Spurio
Browse files

drm/i915/gsc: Skip the version check when fetching the GSC FW 



The current exectation from the FW side is that the driver will query
the GSC FW version after the FW is loaded, similarly to what the mei
driver does on DG2. However, we're discussing with the FW team if there
is a way to extract the version from the bin file before loading, so we
can keep the code the same as for older FWs.

Since the GSC FW version is not currently required for functionality and
is only needed for debug purposes, we can skip the FW version for now at
fetch time and add it later on when we've agreed on the approach.

v2: rebased on uc_fw version struct changes.

Signed-off-by: default avatarDaniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
Cc: Alan Previn <alan.previn.teres.alexis@intel.com>
Cc: John Harrison <John.C.Harrison@Intel.com>
Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com> #v1
Reviewed-by: default avatarAlan Previn <alan.previn.teres.alexis@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20221208200521.2928378-3-daniele.ceraolospurio@intel.com
parent 242c4b91

drivers/gpu/drm/i915/gt/uc/intel_uc_fw.c

+23 −6
Original line number Diff line number Diff line
@@ -655,6 +655,26 @@ static bool guc_check_version_range(struct intel_uc_fw *uc_fw) 
	return true;

}



static int check_fw_header(struct intel_gt *gt,

			   const struct firmware *fw,

			   struct intel_uc_fw *uc_fw)

{

	int err = 0;



	/* GSC FW version is queried after the FW is loaded */

	if (uc_fw->type == INTEL_UC_FW_TYPE_GSC)

		return 0;



	if (uc_fw->loaded_via_gsc)

		err = check_gsc_manifest(fw, uc_fw);

	else

		err = check_ccs_header(gt, fw, uc_fw);

	if (err)

		return err;



	return 0;

}



/**

 * intel_uc_fw_fetch - fetch uC firmware

 * @uc_fw: uC firmware
@@ -724,17 +744,14 @@ int intel_uc_fw_fetch(struct intel_uc_fw *uc_fw) 
	if (err)

		goto fail;



	if (uc_fw->loaded_via_gsc)

		err = check_gsc_manifest(fw, uc_fw);

	else

		err = check_ccs_header(gt, fw, uc_fw);

	err = check_fw_header(gt, fw, uc_fw);

	if (err)

		goto fail;



	if (uc_fw->type == INTEL_UC_FW_TYPE_GUC && !guc_check_version_range(uc_fw))

		goto fail;



	if (uc_fw->file_wanted.ver.major) {

	if (uc_fw->file_wanted.ver.major && uc_fw->file_selected.ver.major) {

		/* Check the file's major version was as it claimed */

		if (uc_fw->file_selected.ver.major != uc_fw->file_wanted.ver.major) {

			drm_notice(&i915->drm, "%s firmware %s: unexpected version: %u.%u != %u.%u\n",
@@ -751,7 +768,7 @@ int intel_uc_fw_fetch(struct intel_uc_fw *uc_fw) 
		}

	}



	if (old_ver) {

	if (old_ver && uc_fw->file_selected.ver.major) {

		/* Preserve the version that was really wanted */

		memcpy(&uc_fw->file_wanted, &file_ideal, sizeof(uc_fw->file_wanted));