Commit f0c16338 authored by Mordechay Goodstein's avatar Mordechay Goodstein Committed by Luca Coelho
Browse files

iwlwifi: dbg: in sync mode don't call schedule 



Today in the code we have two options for collecting data sync/schedule,
the two options call the same function and can lead to racing in free
resources after done.

So we call only one of two sync/schedule, and in case of sync only
call sync function without also schedule to immediately run as a side
job.

Signed-off-by: default avatarMordechay Goodstein <mordechay.goodstein@intel.com>
Signed-off-by: default avatarLuca Coelho <luciano.coelho@intel.com>
Link: https://lore.kernel.org/r/iwlwifi.20220304131517.88574097ce1b.I1b42297619d638d677a2300ed9a95105c1262101@changeid


Signed-off-by: default avatarLuca Coelho <luciano.coelho@intel.com>
parent bb16ffd5

drivers/net/wireless/intel/iwlwifi/fw/dbg.c

+2 −2
Original line number Diff line number Diff line
@@ -2992,10 +2992,10 @@ int iwl_fw_dbg_ini_collect(struct iwl_fw_runtime *fwrt, 
		 "WRT: Collecting data: ini trigger %d fired (delay=%dms).\n",

		 tp_id, (u32)(delay / USEC_PER_MSEC));



	schedule_delayed_work(&fwrt->dump.wks[idx].wk, usecs_to_jiffies(delay));



	if (sync)

		iwl_fw_dbg_collect_sync(fwrt, idx);

	else

		schedule_delayed_work(&fwrt->dump.wks[idx].wk, usecs_to_jiffies(delay));



	return 0;

}