Commit f0a029ff authored Jun 15, 2021 by Tony Luck

EDAC/Intel: Do not load EDAC driver when running as a guest

There's little to no point in loading an EDAC driver running in a guest:
1) The CPU model reported by CPUID may not represent actual h/w
2) The hypervisor likely does not pass in access to memory controller devices
3) Hypervisors generally do not pass corrected error details to guests

Add a check in each of the Intel EDAC drivers for X86_FEATURE_HYPERVISOR
and simply return -ENODEV in the init routine.

Acked-by: Borislav Petkov <bp@suse.de>
Signed-off-by: Tony Luck <tony.luck@intel.com>
Link: https://lore.kernel.org/r/20210615174419.GA1087688@agluck-desk2.amr.corp.intel.com

parent ad774bd5

drivers/edac/i10nm_base.c

+3 −0

Original line number	Diff line number	Diff line
		@@ -414,6 +414,9 @@ static int __init i10nm_init(void)
		if (owner && strncmp(owner, EDAC_MOD_STR, sizeof(EDAC_MOD_STR)))
		return -EBUSY;

		if (cpu_feature_enabled(X86_FEATURE_HYPERVISOR))
		return -ENODEV;

		id = x86_match_cpu(i10nm_cpuids);
		if (!id)
		return -ENODEV;

drivers/edac/pnd2_edac.c

+3 −0

Original line number	Diff line number	Diff line
		@@ -1554,6 +1554,9 @@ static int __init pnd2_init(void)
		if (owner && strncmp(owner, EDAC_MOD_STR, sizeof(EDAC_MOD_STR)))
		return -EBUSY;

		if (cpu_feature_enabled(X86_FEATURE_HYPERVISOR))
		return -ENODEV;

		id = x86_match_cpu(pnd2_cpuids);
		if (!id)
		return -ENODEV;

drivers/edac/sb_edac.c

+3 −0

Original line number	Diff line number	Diff line
		@@ -3510,6 +3510,9 @@ static int __init sbridge_init(void)
		if (owner && strncmp(owner, EDAC_MOD_STR, sizeof(EDAC_MOD_STR)))
		return -EBUSY;

		if (cpu_feature_enabled(X86_FEATURE_HYPERVISOR))
		return -ENODEV;

		id = x86_match_cpu(sbridge_cpuids);
		if (!id)
		return -ENODEV;

drivers/edac/skx_base.c

+3 −0

Original line number	Diff line number	Diff line
		@@ -656,6 +656,9 @@ static int __init skx_init(void)
		if (owner && strncmp(owner, EDAC_MOD_STR, sizeof(EDAC_MOD_STR)))
		return -EBUSY;

		if (cpu_feature_enabled(X86_FEATURE_HYPERVISOR))
		return -ENODEV;

		id = x86_match_cpu(skx_cpuids);
		if (!id)
		return -ENODEV;