Unverified Commit f0691dc1 authored by Dmytro Maluka's avatar Dmytro Maluka Committed by Mark Brown
Browse files

ASoC: da7219: Check for failure reading AAD IRQ events 



When handling an AAD interrupt, if IRQ events read failed (for example,
due to i2c "Transfer while suspended" failure, i.e. when attempting to
read it while DA7219 is suspended, which may happen due to a spurious
AAD interrupt), the events array contains garbage uninitialized values.
So instead of trying to interprete those values and doing any actions
based on them (potentially resulting in misbehavior, e.g. reporting
bogus events), refuse to handle the interrupt.

Signed-off-by: default avatarDmytro Maluka <dmy@semihalf.com>
Link: https://lore.kernel.org/r/20230717193737.161784-3-dmy@semihalf.com


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent 91e29291

sound/soc/codecs/da7219-aad.c

+7 −3
Original line number Diff line number Diff line
@@ -361,11 +361,15 @@ static irqreturn_t da7219_aad_irq_thread(int irq, void *data) 
	struct da7219_priv *da7219 = snd_soc_component_get_drvdata(component);

	u8 events[DA7219_AAD_IRQ_REG_MAX];

	u8 statusa;

	int i, report = 0, mask = 0;

	int i, ret, report = 0, mask = 0;



	/* Read current IRQ events */

	regmap_bulk_read(da7219->regmap, DA7219_ACCDET_IRQ_EVENT_A,

	ret = regmap_bulk_read(da7219->regmap, DA7219_ACCDET_IRQ_EVENT_A,

			       events, DA7219_AAD_IRQ_REG_MAX);

	if (ret) {

		dev_warn_ratelimited(component->dev, "Failed to read IRQ events: %d\n", ret);

		return IRQ_NONE;

	}



	if (!events[DA7219_AAD_IRQ_REG_A] && !events[DA7219_AAD_IRQ_REG_B])

		return IRQ_NONE;