Commit f05c7b7d authored by Kang Chen's avatar Kang Chen Committed by Daniel Lezcano
Browse files

thermal/drivers/mediatek: Use devm_of_iomap to avoid resource leak in mtk_thermal_probe 



Smatch reports:
1. mtk_thermal_probe() warn: 'apmixed_base' from of_iomap() not released.
2. mtk_thermal_probe() warn: 'auxadc_base' from of_iomap() not released.

The original code forgets to release iomap resource when handling errors,
fix it by switch to devm_of_iomap.

Fixes: 89945047 ("thermal: mediatek: Add tsensor support for V2 thermal system")
Signed-off-by: default avatarKang Chen <void0red@hust.edu.cn>
Reviewed-by: default avatarDongliang Mu <dzm91@hust.edu.cn>
Reviewed-by: default avatarAngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Signed-off-by: default avatarDaniel Lezcano <daniel.lezcano@linaro.org>
Link: https://lore.kernel.org/r/20230419020749.621257-1-void0red@hust.edu.cn
parent 47cbb046

drivers/thermal/mediatek/auxadc_thermal.c

+12 −2
Original line number Diff line number Diff line
@@ -1232,7 +1232,12 @@ static int mtk_thermal_probe(struct platform_device *pdev) 
		return -ENODEV;

	}



	auxadc_base = of_iomap(auxadc, 0);

	auxadc_base = devm_of_iomap(&pdev->dev, auxadc, 0, NULL);

	if (IS_ERR(auxadc_base)) {

		of_node_put(auxadc);

		return PTR_ERR(auxadc_base);

	}



	auxadc_phys_base = of_get_phys_base(auxadc);



	of_node_put(auxadc);
@@ -1248,7 +1253,12 @@ static int mtk_thermal_probe(struct platform_device *pdev) 
		return -ENODEV;

	}



	apmixed_base = of_iomap(apmixedsys, 0);

	apmixed_base = devm_of_iomap(&pdev->dev, apmixedsys, 0, NULL);

	if (IS_ERR(apmixed_base)) {

		of_node_put(apmixedsys);

		return PTR_ERR(apmixed_base);

	}



	apmixed_phys_base = of_get_phys_base(apmixedsys);



	of_node_put(apmixedsys);