Commit f0417e72 authored by Eli Cohen's avatar Eli Cohen Committed by Michael S. Tsirkin
Browse files

vdpa/mlx5: Add and remove debugfs in setup/teardown driver 



The right place to add the debugfs create is in
setup_driver() and remove it in teardown_driver().

Current code adds the debugfs when creating the device but resetting a
device will remove the debugfs subtree and subsequent set_driver will
not be able to create the files since the debugfs pointer is NULL.

Fixes: 29422100 ("vdpa/mlx5: Add debugfs subtree")
Signed-off-by: default avatarEli Cohen <elic@nvidia.com>

v3 -> v4:
Fix error flow in setup_driver()
Message-Id: <20230403114039.11102-1-elic@nvidia.com>

Signed-off-by: default avatarMichael S. Tsirkin <mst@redhat.com>
Acked-by: default avatarJason Wang <jasowang@redhat.com>
parent 9513c55c

drivers/vdpa/mlx5/net/mlx5_vnet.c

+6 −2
Original line number Diff line number Diff line
@@ -2467,10 +2467,11 @@ static int setup_driver(struct mlx5_vdpa_dev *mvdev) 
		err = 0;

		goto out;

	}

	mlx5_vdpa_add_debugfs(ndev);

	err = setup_virtqueues(mvdev);

	if (err) {

		mlx5_vdpa_warn(mvdev, "setup_virtqueues\n");

		goto out;

		goto err_setup;

	}



	err = create_rqt(ndev);
@@ -2500,6 +2501,8 @@ static int setup_driver(struct mlx5_vdpa_dev *mvdev) 
	destroy_rqt(ndev);

err_rqt:

	teardown_virtqueues(ndev);

err_setup:

	mlx5_vdpa_remove_debugfs(ndev->debugfs);

out:

	return err;

}
@@ -2513,6 +2516,8 @@ static void teardown_driver(struct mlx5_vdpa_net *ndev) 
	if (!ndev->setup)

		return;



	mlx5_vdpa_remove_debugfs(ndev->debugfs);

	ndev->debugfs = NULL;

	teardown_steering(ndev);

	destroy_tir(ndev);

	destroy_rqt(ndev);
@@ -3261,7 +3266,6 @@ static int mlx5_vdpa_dev_add(struct vdpa_mgmt_dev *v_mdev, const char *name, 
	if (err)

		goto err_reg;



	mlx5_vdpa_add_debugfs(ndev);

	mgtdev->ndev = ndev;

	return 0;