Commit f0406481 authored by Hannes Reinecke's avatar Hannes Reinecke Committed by Christoph Hellwig
Browse files

nvmet: fixup buffer overrun in nvmet_subsys_attr_serial() 



The serial number is copied into the buffer via memcpy_and_pad()
with the length NVMET_SN_MAX_SIZE. So when printing out we also
need to take just that length as anything beyond that will be
uninitialized.

Signed-off-by: default avatarHannes Reinecke <hare@suse.de>
Signed-off-by: default avatarChristoph Hellwig <hch@lst.de>
parent ab7a2737

drivers/nvme/target/configfs.c

+2 −1
Original line number Diff line number Diff line
@@ -1067,7 +1067,8 @@ static ssize_t nvmet_subsys_attr_serial_show(struct config_item *item, 
{

	struct nvmet_subsys *subsys = to_subsys(item);



	return snprintf(page, PAGE_SIZE, "%s\n", subsys->serial);

	return snprintf(page, PAGE_SIZE, "%*s\n",

			NVMET_SN_MAX_SIZE, subsys->serial);

}



static ssize_t