Commit f0101af4 authored Aug 02, 2021 by Bean Huo Committed by Martin K. Petersen Aug 05, 2021

scsi: ufs: core: Remove redundant call in ufshcd_add_command_trace()

ufshcd_add_cmd_upiu_trace() will be called later anyway. Simplify code by
moving if-statement.

Link: https://lore.kernel.org/r/20210802180803.100033-1-huobean@gmail.com


Reviewed-by: Avri Altman <avri.altman@wdc.com>
Signed-off-by: Bean Huo <beanhuo@micron.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>

parent 77d0f07a

drivers/scsi/ufs/ufshcd.c

+3 −6

Original line number	Diff line number	Diff line
		@@ -369,14 +369,11 @@ static void ufshcd_add_command_trace(struct ufs_hba *hba, unsigned int tag,
		if (!cmd)
		return;

		if (!trace_ufshcd_command_enabled()) {
		/* trace UPIU W/O tracing command */
		/* trace UPIU also */
		ufshcd_add_cmd_upiu_trace(hba, tag, str_t);
		if (!trace_ufshcd_command_enabled())
		return;
		}

		/* trace UPIU also */
		ufshcd_add_cmd_upiu_trace(hba, tag, str_t);
		opcode = cmd->cmnd[0];
		lba = scsi_get_lba(cmd);