Commit eff6aa17 authored by Rong Tao's avatar Rong Tao Committed by Andrew Morton
Browse files

selftests/damon: fix unnecessary compilation warnings 

When testing overflow and overread, there is no need to keep unnecessary
compilation warnings, we should simply ignore them.

The motivation for this patch is to eliminate the compilation warning,
maybe one day we will compile the kernel with "-Werror -Wall", at which
point this compilation warning will turn into a compilation error, we
should fix this error in advance.

How to reproduce the problem (with gcc-11.3.1):

    $ make -C tools/testing/selftests/
    ...
    warning: `write' reading 4294967295 bytes from a region of size 1
    [-Wstringop-overread]
    warning: `read' writing 4294967295 bytes into a region of size 25
    overflows the destination [-Wstringop-overflow=]

"-Wno-stringop-overread" is supported at least in gcc-11.1.0.

Link: https://gcc.gnu.org/git/?p=gcc.git;a=commit;h=d14c547abd484d3540b692bb8048c4a6efe92c8b
Link: https://lkml.kernel.org/r/tencent_51C4ACA8CB3895C2D7F35178440283602107@qq.com


Signed-off-by: default avatarRong Tao <rongtao@cestc.cn>
Reviewed-by: default avatarSeongJae Park <sj@kernel.org>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
parent dbaf7dc9

tools/testing/selftests/damon/huge_count_read_write.c

+9 −0
Original line number Diff line number Diff line
@@ -8,6 +8,13 @@ 
#include <unistd.h>

#include <stdio.h>



#pragma GCC diagnostic push

#if __GNUC__ >= 11 && __GNUC_MINOR__ >= 1

/* Ignore read(2) overflow and write(2) overread compile warnings */

#pragma GCC diagnostic ignored "-Wstringop-overread"

#pragma GCC diagnostic ignored "-Wstringop-overflow"

#endif



void write_read_with_huge_count(char *file)

{

	int filedesc = open(file, O_RDWR);
@@ -27,6 +34,8 @@ void write_read_with_huge_count(char *file) 
	close(filedesc);

}



#pragma GCC diagnostic pop



int main(int argc, char *argv[])

{

	if (argc != 2) {