Commit eff4780f authored by Miaoqian Lin's avatar Miaoqian Lin Committed by Marc Zyngier
Browse files

irqchip/realtek-rtl: Fix refcount leak in map_interrupts 



of_find_node_by_phandle() returns a node pointer with refcount
incremented, we should use of_node_put() on it when not need anymore.
This function doesn't call of_node_put() in error path.
Call of_node_put() directly after of_property_read_u32() to cover
both normal path and error path.

Fixes: 9f3a0f34 ("irqchip: Add support for Realtek RTL838x/RTL839x interrupt controller")
Signed-off-by: default avatarMiaoqian Lin <linmq006@gmail.com>
Signed-off-by: default avatarMarc Zyngier <maz@kernel.org>
Link: https://lore.kernel.org/r/20220601080930.31005-7-linmq006@gmail.com
parent fa1ad9d4

drivers/irqchip/irq-realtek-rtl.c

+1 −1
Original line number Diff line number Diff line
@@ -134,9 +134,9 @@ static int __init map_interrupts(struct device_node *node, struct irq_domain *do 
		if (!cpu_ictl)

			return -EINVAL;

		ret = of_property_read_u32(cpu_ictl, "#interrupt-cells", &tmp);

		of_node_put(cpu_ictl);

		if (ret || tmp != 1)

			return -EINVAL;

		of_node_put(cpu_ictl);



		cpu_int = be32_to_cpup(imap + 2);

		if (cpu_int > 7 || cpu_int < 2)