Commit eff21f5d authored May 04, 2021 by Christophe JAILLET Committed by Lorenzo Pieralisi Aug 05, 2021

PCI: tegra: Fix OF node reference leak

Commit 9e38e690 ("PCI: tegra: Fix OF node reference leak") has fixed
some node reference leaks in this function but missed some of them.

In fact, having 'port' referenced in the 'rp' structure is not enough to
prevent the leak, until 'rp' is actually added in the 'pcie->ports' list.

Add the missing 'goto err_node_put' accordingly.

Link: https://lore.kernel.org/r/55b11e9a7fa2987fbc0869d68ae59888954d65e2.1620148539.git.christophe.jaillet@wanadoo.fr

Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Signed-off-by: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
Reviewed-by: Vidya Sagar <vidyas@nvidia.com>

parent 6310a152

drivers/pci/controller/pci-tegra.c

+8 −5

Original line number	Diff line number	Diff line
		@@ -2188,13 +2188,15 @@ static int tegra_pcie_parse_dt(struct tegra_pcie *pcie)
		rp->np = port;

		rp->base = devm_pci_remap_cfg_resource(dev, &rp->regs);
		if (IS_ERR(rp->base))
		return PTR_ERR(rp->base);
		if (IS_ERR(rp->base)) {
		err = PTR_ERR(rp->base);
		goto err_node_put;
		}

		label = devm_kasprintf(dev, GFP_KERNEL, "pex-reset-%u", index);
		if (!label) {
		dev_err(dev, "failed to create reset GPIO label\n");
		return -ENOMEM;
		err = -ENOMEM;
		goto err_node_put;
		}

		/*
		@@ -2212,7 +2214,8 @@ static int tegra_pcie_parse_dt(struct tegra_pcie *pcie)
		} else {
		dev_err(dev, "failed to get reset GPIO: %ld\n",
		PTR_ERR(rp->reset_gpio));
		return PTR_ERR(rp->reset_gpio);
		err = PTR_ERR(rp->reset_gpio);
		goto err_node_put;
		}
		}