Commit efe34e99 authored by Beau Belgrave's avatar Beau Belgrave Committed by Steven Rostedt (Google)
Browse files

tracing/user_events: Hold event_mutex during dyn_event_add 

Make sure the event_mutex is properly held during dyn_event_add call.
This is required when adding dynamic events.

Link: https://lkml.kernel.org/r/20220328223225.1992-1-beaub@linux.microsoft.com



Reported-by: default avatarMathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: default avatarBeau Belgrave <beaub@linux.microsoft.com>
Acked-by: default avatarMasami Hiramatsu <mhiramat@kernel.org>
Signed-off-by: default avatarSteven Rostedt (Google) <rostedt@goodmis.org>
parent bed5b60b

kernel/trace/trace_events_user.c

+6 −2
Original line number Diff line number Diff line
@@ -1165,11 +1165,11 @@ static int user_event_parse(char *name, char *args, char *flags, 
#endif



	mutex_lock(&event_mutex);



	ret = user_event_trace_register(user);

	mutex_unlock(&event_mutex);



	if (ret)

		goto put_user;

		goto put_user_lock;



	user->index = index;
@@ -1181,8 +1181,12 @@ static int user_event_parse(char *name, char *args, char *flags, 
	set_bit(user->index, page_bitmap);

	hash_add(register_table, &user->node, key);



	mutex_unlock(&event_mutex);



	*newuser = user;

	return 0;

put_user_lock:

	mutex_unlock(&event_mutex);

put_user:

	user_event_destroy_fields(user);

	user_event_destroy_validators(user);