Commit efccf655 authored by Hao Chen's avatar Hao Chen Committed by Paolo Abeni
Browse files

net: hns3: fix byte order conversion issue in hclge_dbg_fd_tcam_read() 



req1->tcam_data is defined as "u8 tcam_data[8]", and we convert it as
(u32 *) without considerring byte order conversion,
it may result in printing wrong data for tcam_data.

Convert tcam_data to (__le32 *) first to fix it.

Fixes: b5a0b70d ("net: hns3: refactor dump fd tcam of debugfs")
Signed-off-by: default avatarHao Chen <chenhao418@huawei.com>
Signed-off-by: default avatarJijie Shao <shaojijie@huawei.com>
Signed-off-by: default avatarPaolo Abeni <pabeni@redhat.com>
parent dd2bbc2e

drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_debugfs.c

+7 −7
Original line number Diff line number Diff line
@@ -1519,7 +1519,7 @@ static int hclge_dbg_fd_tcam_read(struct hclge_dev *hdev, bool sel_x, 
	struct hclge_desc desc[3];

	int pos = 0;

	int ret, i;

	u32 *req;

	__le32 *req;



	hclge_cmd_setup_basic_desc(&desc[0], HCLGE_OPC_FD_TCAM_OP, true);

	desc[0].flag |= cpu_to_le16(HCLGE_COMM_CMD_FLAG_NEXT);
@@ -1544,22 +1544,22 @@ static int hclge_dbg_fd_tcam_read(struct hclge_dev *hdev, bool sel_x, 
			 tcam_msg.loc);



	/* tcam_data0 ~ tcam_data1 */

	req = (u32 *)req1->tcam_data;

	req = (__le32 *)req1->tcam_data;

	for (i = 0; i < 2; i++)

		pos += scnprintf(tcam_buf + pos, HCLGE_DBG_TCAM_BUF_SIZE - pos,

				 "%08x\n", *req++);

				 "%08x\n", le32_to_cpu(*req++));



	/* tcam_data2 ~ tcam_data7 */

	req = (u32 *)req2->tcam_data;

	req = (__le32 *)req2->tcam_data;

	for (i = 0; i < 6; i++)

		pos += scnprintf(tcam_buf + pos, HCLGE_DBG_TCAM_BUF_SIZE - pos,

				 "%08x\n", *req++);

				 "%08x\n", le32_to_cpu(*req++));



	/* tcam_data8 ~ tcam_data12 */

	req = (u32 *)req3->tcam_data;

	req = (__le32 *)req3->tcam_data;

	for (i = 0; i < 5; i++)

		pos += scnprintf(tcam_buf + pos, HCLGE_DBG_TCAM_BUF_SIZE - pos,

				 "%08x\n", *req++);

				 "%08x\n", le32_to_cpu(*req++));



	return ret;

}