Commit efc9812e authored by Heikki Krogerus's avatar Heikki Krogerus Committed by Greg Kroah-Hartman
Browse files

usb: dwc3: haps: Constify the software node 



What platform_device_add_properties() does is it allocates
dynamically a software node that will contain the device
properties supplied to it, and then couples that node with
the device. Since that node is always created, it might as
well be constant.

Signed-off-by: default avatarHeikki Krogerus <heikki.krogerus@linux.intel.com>
Link: https://lore.kernel.org/r/20210204141711.53775-4-heikki.krogerus@linux.intel.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent e81dee55

drivers/usb/dwc3/dwc3-haps.c

+7 −1
Original line number Diff line number Diff line
@@ -33,6 +33,10 @@ static const struct property_entry initial_properties[] = { 
	{ },

};



static const struct software_node dwc3_haps_swnode = {

	.properties = initial_properties,

};



static int dwc3_haps_probe(struct pci_dev *pci,

			   const struct pci_device_id *id)

{
@@ -77,7 +81,7 @@ static int dwc3_haps_probe(struct pci_dev *pci, 
	dwc->pci = pci;

	dwc->dwc3->dev.parent = dev;



	ret = platform_device_add_properties(dwc->dwc3, initial_properties);

	ret = device_add_software_node(&dwc->dwc3->dev, &dwc3_haps_swnode);

	if (ret)

		goto err;
@@ -91,6 +95,7 @@ static int dwc3_haps_probe(struct pci_dev *pci, 


	return 0;

err:

	device_remove_software_node(&dwc->dwc3->dev);

	platform_device_put(dwc->dwc3);

	return ret;

}
@@ -99,6 +104,7 @@ static void dwc3_haps_remove(struct pci_dev *pci) 
{

	struct dwc3_haps *dwc = pci_get_drvdata(pci);



	device_remove_software_node(&dwc->dwc3->dev);

	platform_device_unregister(dwc->dwc3);

}