Commit efb389b8 authored by Uwe Kleine-König's avatar Uwe Kleine-König Committed by Guenter Roeck
Browse files

hwmon: (max31722) Warn about failure to put device in stand-by in .remove()



When an spi driver's remove function returns a non-zero error code
nothing happens apart from emitting a generic error message. Make this
error message more device specific and return zero instead.

Acked-by: default avatarMichael Hennerich <michael.hennerich@analog.com>
Signed-off-by: default avatarUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Link: https://lore.kernel.org/r/20211012153945.2651412-5-u.kleine-koenig@pengutronix.de


Signed-off-by: default avatarGuenter Roeck <linux@roeck-us.net>
parent 2c59a32d
Loading
Loading
Loading
Loading
+7 −1
Original line number Diff line number Diff line
@@ -103,10 +103,16 @@ static int max31722_probe(struct spi_device *spi)
static int max31722_remove(struct spi_device *spi)
{
	struct max31722_data *data = spi_get_drvdata(spi);
	int ret;

	hwmon_device_unregister(data->hwmon_dev);

	return max31722_set_mode(data, MAX31722_MODE_STANDBY);
	ret = max31722_set_mode(data, MAX31722_MODE_STANDBY);
	if (ret)
		/* There is nothing we can do about this ... */
		dev_warn(&spi->dev, "Failed to put device in stand-by mode\n");

	return 0;
}

static int __maybe_unused max31722_suspend(struct device *dev)