Commit ef9c00db authored Jan 04, 2023 by Prashant Malani

platform/chrome: cros_typec_switch: Use fwnode* prop check

Using device_property_present() multiple times on an ACPI device
leads to kernel panics on Chromebook systems. This happens when there
is > 1 boolean property in an ACPI device which is created dynamically
by the BIOS as part of SSDT[1] on Chromebook systems

Since fwnode_* can handle simple device tree properties equally
well, switch to using the fwnode_property_present() function
version. This will avoid panics and make the usage consistent
when we introduce a check for the 2nd property in a subsequent patch.

[1] https://wiki.osdev.org/SSDT



Signed-off-by: Prashant Malani <pmalani@chromium.org>
Reviewed-by: Benson Leung <bleung@chromium.org>
Link: https://lore.kernel.org/r/20230104060846.112216-1-pmalani@chromium.org

parent 40a9b13a

drivers/platform/chrome/cros_typec_switch.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -254,7 +254,7 @@ static int cros_typec_register_switches(struct cros_typec_switch_data *sdata)

		dev_dbg(dev, "Retimer switch registered for index %llu\n", index);

		if (!device_property_present(fwnode->dev, "mode-switch"))
		if (!fwnode_property_present(fwnode, "mode-switch"))
		continue;

		ret = cros_typec_register_mode_switch(port, fwnode);