Unverified Commit ef8886f3 authored Jul 27, 2022 by Zeng Jingxiang Committed by Robert Foss Aug 08, 2022

gpu: lontium-lt9611: Fix NULL pointer dereference in lt9611_connector_init()



A NULL check for bridge->encoder shows that it may be NULL, but it
already been dereferenced on all paths leading to the check.
812	if (!bridge->encoder) {

Dereference the pointer bridge->encoder.
810	drm_connector_attach_encoder(&lt9611->connector, bridge->encoder);

Signed-off-by: Zeng Jingxiang <linuszeng@tencent.com>
Signed-off-by: Robert Foss <robert.foss@linaro.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20220727073119.1578972-1-zengjx95@gmail.com

parent de40c281

drivers/gpu/drm/bridge/lontium-lt9611.c

+2 −1

Original line number	Diff line number	Diff line
		@@ -813,13 +813,14 @@ static int lt9611_connector_init(struct drm_bridge bridge, struct lt9611 lt961

		drm_connector_helper_add(&lt9611->connector,
		&lt9611_bridge_connector_helper_funcs);
		drm_connector_attach_encoder(&lt9611->connector, bridge->encoder);

		if (!bridge->encoder) {
		DRM_ERROR("Parent encoder object not found");
		return -ENODEV;
		}

		drm_connector_attach_encoder(&lt9611->connector, bridge->encoder);

		return 0;
		}