Commit ef7ec41f authored by Ville Syrjälä's avatar Ville Syrjälä
Browse files

drm/i915: Replace the unconditional clflush with drm_clflush_virt_range() 



Not all machines have clflush, so don't go assuming they do.
Not really sure why the clflush is even here since hwsp
is supposed to get snooped I thought.

Although in my case we're talking about a i830 machine where
render/blitter snooping is definitely busted. But it might
work for the hswp perhaps. Haven't really reverse engineered
that one fully.

Cc: stable@vger.kernel.org
Cc: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Mika Kuoppala <mika.kuoppala@linux.intel.com>
Fixes: b436a5f8 ("drm/i915/gt: Track all timelines created using the HWSP")
Signed-off-by: default avatarVille Syrjälä <ville.syrjala@linux.intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20211014090941.12159-2-ville.syrjala@linux.intel.com


Reviewed-by: default avatarDave Airlie <airlied@redhat.com>
parent 4eb61ddc

drivers/gpu/drm/i915/gt/intel_ring_submission.c

+1 −1
Original line number Diff line number Diff line
@@ -292,7 +292,7 @@ static void xcs_sanitize(struct intel_engine_cs *engine) 
	sanitize_hwsp(engine);



	/* And scrub the dirty cachelines for the HWSP */

	clflush_cache_range(engine->status_page.addr, PAGE_SIZE);

	drm_clflush_virt_range(engine->status_page.addr, PAGE_SIZE);



	intel_engine_reset_pinned_contexts(engine);

}