Commit ef753fb4 authored by Andy Shevchenko's avatar Andy Shevchenko Committed by Chanwoo Choi
Browse files

extcon: Use sizeof(*pointer) instead of sizeof(type) 



It is preferred to use sizeof(*pointer) instead of sizeof(type).
The type of the variable can change and one needs not change
the former (unlike the latter). No functional change intended.

Signed-off-by: default avatarAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: default avatarChanwoo Choi <cw00.choi@samsung.com>
parent 7bba9e81

drivers/extcon/extcon.c

+5 −8
Original line number Diff line number Diff line
@@ -1098,8 +1098,7 @@ static int extcon_alloc_cables(struct extcon_dev *edev) 
	if (!edev->max_supported)

		return 0;



	edev->cables = kcalloc(edev->max_supported,

			       sizeof(struct extcon_cable),

	edev->cables = kcalloc(edev->max_supported, sizeof(*edev->cables),

			       GFP_KERNEL);

	if (!edev->cables)

		return -ENOMEM;
@@ -1161,14 +1160,12 @@ static int extcon_alloc_muex(struct extcon_dev *edev) 
	for (index = 0; edev->mutually_exclusive[index]; index++)

		;



	edev->attrs_muex = kcalloc(index + 1,

				   sizeof(struct attribute *),

	edev->attrs_muex = kcalloc(index + 1, sizeof(*edev->attrs_muex),

				   GFP_KERNEL);

	if (!edev->attrs_muex)

		return -ENOMEM;



	edev->d_attrs_muex = kcalloc(index,

				     sizeof(struct device_attribute),

	edev->d_attrs_muex = kcalloc(index, sizeof(*edev->d_attrs_muex),

				     GFP_KERNEL);

	if (!edev->d_attrs_muex) {

		kfree(edev->attrs_muex);
@@ -1214,7 +1211,7 @@ static int extcon_alloc_groups(struct extcon_dev *edev) 
		return 0;



	edev->extcon_dev_type.groups = kcalloc(edev->max_supported + 2,

			sizeof(struct attribute_group *),

					  sizeof(*edev->extcon_dev_type.groups),

					  GFP_KERNEL);

	if (!edev->extcon_dev_type.groups)

		return -ENOMEM;