Commit ef642510 authored by Vaibhav Gupta's avatar Vaibhav Gupta Committed by Kalle Valo
Browse files

rtl818x_pci: use generic power management 



Earlier, drivers had to manage the device's power states, and related
operations, themselves. With the generic approach, these are done by PCI
core.

The only driver-specific jobs, .suspend() and .resume() doing were invoking
PCI helper functions pci_save/restore_state() and
pci_set_power_state(). This is not recommeneded as PCI core takes care of
that. Hence they became empty-body functions, thus define them NULL.

Compile-tested only.

Signed-off-by: default avatarVaibhav Gupta <vaibhavgupta40@gmail.com>
Signed-off-by: default avatarKalle Valo <kvalo@codeaurora.org>
Link: https://lore.kernel.org/r/20200623094454.12427-1-vaibhavgupta40@gmail.com
parent a7f7c15e

drivers/net/wireless/realtek/rtl818x/rtl8180/dev.c

+4 −19
Original line number Diff line number Diff line
@@ -1966,32 +1966,17 @@ static void rtl8180_remove(struct pci_dev *pdev) 
	ieee80211_free_hw(dev);

}



#ifdef CONFIG_PM

static int rtl8180_suspend(struct pci_dev *pdev, pm_message_t state)

{

	pci_save_state(pdev);

	pci_set_power_state(pdev, pci_choose_state(pdev, state));

	return 0;

}



static int rtl8180_resume(struct pci_dev *pdev)

{

	pci_set_power_state(pdev, PCI_D0);

	pci_restore_state(pdev);

	return 0;

}

#define rtl8180_suspend NULL

#define rtl8180_resume NULL



#endif /* CONFIG_PM */

static SIMPLE_DEV_PM_OPS(rtl8180_pm_ops, rtl8180_suspend, rtl8180_resume);



static struct pci_driver rtl8180_driver = {

	.name		= KBUILD_MODNAME,

	.id_table	= rtl8180_table,

	.probe		= rtl8180_probe,

	.remove		= rtl8180_remove,

#ifdef CONFIG_PM

	.suspend	= rtl8180_suspend,

	.resume		= rtl8180_resume,

#endif /* CONFIG_PM */

	.driver.pm	= &rtl8180_pm_ops,

};



module_pci_driver(rtl8180_driver);