Unverified Commit ef51cd1e authored by Peter Ujfalusi's avatar Peter Ujfalusi Committed by Mark Brown
Browse files

ASoC: SOF: ipc4-topology: Initialize in_format to NULL in sof_ipc4_get_audio_fmt 



If the available_fmt->num_input_formats is 0 and there is a failure during
the output format parsing then a kfree() would be called on the
uninitialized in_format pointer.

By initializing the in_format to NULL, this error can be avoided.

Fixes: 7ab6b1e8 ("ASoC: SOF: ipc4-topology: Modify the type of available input/output formats")
Signed-off-by: default avatarPeter Ujfalusi <peter.ujfalusi@linux.intel.com>
Reviewed-by: default avatarBard Liao <yung-chuan.liao@linux.intel.com>
Reviewed-by: default avatarPierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Reviewed-by: default avatarRanjani Sridharan <ranjani.sridharan@linux.intel.com>
Link: https://lore.kernel.org/r/20230317063524.8280-1-peter.ujfalusi@linux.intel.com


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent 1d8777d2

sound/soc/sof/ipc4-topology.c

+2 −1
Original line number Diff line number Diff line
@@ -179,7 +179,8 @@ static int sof_ipc4_get_audio_fmt(struct snd_soc_component *scomp, 
				  struct sof_ipc4_available_audio_format *available_fmt,

				  struct sof_ipc4_base_module_cfg *module_base_cfg)

{

	struct sof_ipc4_pin_format *out_format, *in_format;

	struct sof_ipc4_pin_format *in_format = NULL;

	struct sof_ipc4_pin_format *out_format;

	int ret;



	ret = sof_update_ipc_object(scomp, available_fmt,