Commit ef39d632 authored by liaoguojia's avatar liaoguojia Committed by David S. Miller
Browse files

net: hns3: check vlan id before using it 



The input parameters may not be reliable, so check the vlan id before
using it, otherwise may set wrong vlan id into hardware.

Fixes: dc8131d8 ("net: hns3: Fix for packet loss due wrong filter config in VLAN tbls")
Signed-off-by: default avatarliaoguojia <liaoguojia@huawei.com>
Signed-off-by: default avatarGuangbin Huang <huangguangbin2@huawei.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 63b1279d

drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c

+3 −0
Original line number Diff line number Diff line
@@ -9817,6 +9817,9 @@ static int hclge_set_vlan_filter_hw(struct hclge_dev *hdev, __be16 proto, 
	if (is_kill && !vlan_id)

		return 0;



	if (vlan_id >= VLAN_N_VID)

		return -EINVAL;



	ret = hclge_set_vf_vlan_common(hdev, vport_id, is_kill, vlan_id);

	if (ret) {

		dev_err(&hdev->pdev->dev,