Commit ef1bc119 authored by Dan Carpenter's avatar Dan Carpenter Committed by Jakub Kicinski
Browse files

net: fix signedness bug in skb_splice_from_iter() 



The "len" variable needs to be signed for the error handling to work
correctly.

Fixes: 2e910b95 ("net: Add a function to splice pages into an skbuff for MSG_SPLICE_PAGES")
Signed-off-by: default avatarDan Carpenter <dan.carpenter@linaro.org>
Reviewed-by: default avatarDavid Howells <dhowells@redhat.com>
Reviewed-by: default avatarJiri Pirko <jiri@nvidia.com>
Link: https://lore.kernel.org/r/366861a7-87c8-4bbf-9101-69dd41021d07@kili.mountain


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 404621fa

net/core/skbuff.c

+2 −2
Original line number Diff line number Diff line
@@ -6931,8 +6931,8 @@ ssize_t skb_splice_from_iter(struct sk_buff *skb, struct iov_iter *iter, 
	unsigned int i;



	while (iter->count > 0) {

		ssize_t space, nr;

		size_t off, len;

		ssize_t space, nr, len;

		size_t off;



		ret = -EMSGSIZE;

		space = frag_limit - skb_shinfo(skb)->nr_frags;