Commit ef1661ba authored Oct 29, 2021 by Jean Sacren Committed by Jens Axboe Oct 30, 2021

blk-mq: fix redundant check of !e expression



In the if branch, e is checked.  In the else branch, ->dispatch_busy is
merely a number and has no effect on !e.  We should remove the check of
!e since it is always true.

Signed-off-by: Jean Sacren <sakiwit@gmail.com>
Link: https://lore.kernel.org/r/20211029202945.3052-1-sakiwit@gmail.com


Signed-off-by: Jens Axboe <axboe@kernel.dk>

parent 9b84c629

block/blk-mq-sched.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -497,7 +497,7 @@ void blk_mq_sched_insert_requests(struct blk_mq_hw_ctx *hctx,
		* busy in case of 'none' scheduler, and this way may save
		* us one extra enqueue & dequeue to sw queue.
		*/
		if (!hctx->dispatch_busy && !e && !run_queue_async) {
		if (!hctx->dispatch_busy && !run_queue_async) {
		blk_mq_try_issue_list_directly(hctx, list);
		if (list_empty(list))
		goto out;