Commit ef14f0e8 authored by Hans de Goede's avatar Hans de Goede
Browse files

platform/x86: acer-wmi: Don't use ACPI_EXCEPTION() 



ACPI_EXCEPTION is only intended for internal use by the ACPICA code.

ACPI_EXCEPTION was being used here to change the apci_status code into
something human-readable, use acpi_format_exception() for this instead,
which is the proper way to do this outside of ACPICA.

Signed-off-by: default avatarHans de Goede <hdegoede@redhat.com>
Link: https://lore.kernel.org/r/20210204140205.268344-1-hdegoede@redhat.com
parent 9aa422f6

drivers/platform/x86/acer-wmi.c

+2 −2
Original line number Diff line number Diff line
@@ -30,7 +30,6 @@ 
#include <linux/input/sparse-keymap.h>

#include <acpi/video.h>



ACPI_MODULE_NAME(KBUILD_MODNAME);

MODULE_AUTHOR("Carlos Corbacho");

MODULE_DESCRIPTION("Acer Laptop WMI Extras Driver");

MODULE_LICENSE("GPL");
@@ -1605,7 +1604,8 @@ static void acer_kbd_dock_get_initial_state(void) 


	status = wmi_evaluate_method(WMID_GUID3, 0, 0x2, &input_buf, &output_buf);

	if (ACPI_FAILURE(status)) {

		ACPI_EXCEPTION((AE_INFO, status, "Error getting keyboard-dock initial status"));

		pr_err("Error getting keyboard-dock initial status: %s\n",

		       acpi_format_exception(status));

		return;

	}