Commit ef12a141 authored by Arnaldo Carvalho de Melo's avatar Arnaldo Carvalho de Melo Committed by Ingo Molnar
Browse files

perf buildid-cache: Add new command to manage build-id cache 



For now it just has operations to examine a given file, find its
build-id and add or remove it to/from the cache.

Useful, for instance, when adding binaries sent together with a
perf.data file, so that we can add them to the cache and have
the tools find it when resolving symbols.

It'll also manage the size of the cache like 'ccache' does.

Signed-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
Cc: Frédéric Weisbecker <fweisbec@gmail.com>
Cc: Mike Galbraith <efault@gmx.de>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Paul Mackerras <paulus@samba.org>
LKML-Reference: <1264008525-29025-1-git-send-email-acme@infradead.org>
Signed-off-by: default avatarIngo Molnar <mingo@elte.hu>
parent dc8d6ab2

tools/perf/Documentation/perf-buildid-cache.txt

0 → 100644
+33 −0
Original line number Diff line number Diff line 
perf-buildid-cache(1)

=====================



NAME

----

perf-buildid-cache - Manage build-id cache.



SYNOPSIS

--------

[verse]

'perf buildid-list <options>'



DESCRIPTION

-----------

This command manages the build-id cache. It can add and remove files to the

cache. In the future it should as well purge older entries, set upper limits

for the space used by the cache, etc.



OPTIONS

-------

-a::

--add=::

        Add specified file to the cache.

-r::

--remove=::

        Remove specified file to the cache.

-v::

--verbose::

	Be more verbose.



SEE ALSO

--------

linkperf:perf-record[1], linkperf:perf-report[1]

tools/perf/Makefile

+1 −0
Original line number Diff line number Diff line
@@ -445,6 +445,7 @@ BUILTIN_OBJS += builtin-diff.o 
BUILTIN_OBJS += builtin-help.o

BUILTIN_OBJS += builtin-sched.o

BUILTIN_OBJS += builtin-buildid-list.o

BUILTIN_OBJS += builtin-buildid-cache.o

BUILTIN_OBJS += builtin-list.o

BUILTIN_OBJS += builtin-record.o

BUILTIN_OBJS += builtin-report.o

tools/perf/builtin-buildid-cache.c

0 → 100644
+133 −0
Original line number Diff line number Diff line 
/*

 * builtin-buildid-cache.c

 *

 * Builtin buildid-cache command: Manages build-id cache

 *

 * Copyright (C) 2010, Red Hat Inc.

 * Copyright (C) 2010, Arnaldo Carvalho de Melo <acme@redhat.com>

 */

#include "builtin.h"

#include "perf.h"

#include "util/cache.h"

#include "util/debug.h"

#include "util/header.h"

#include "util/parse-options.h"

#include "util/strlist.h"

#include "util/symbol.h"



static char const *add_name_list_str, *remove_name_list_str;



static const char * const buildid_cache_usage[] = {

	"perf buildid-cache [<options>]",

	NULL

};



static const struct option buildid_cache_options[] = {

	OPT_STRING('a', "add", &add_name_list_str,

		   "file list", "file(s) to add"),

	OPT_STRING('r', "remove", &remove_name_list_str, "file list",

		    "file(s) to remove"),

	OPT_BOOLEAN('v', "verbose", &verbose, "be more verbose"),

	OPT_END()

};



static int build_id_cache__add_file(const char *filename, const char *debugdir)

{

	char sbuild_id[BUILD_ID_SIZE * 2 + 1];

	u8 build_id[BUILD_ID_SIZE];

	int err;



	if (filename__read_build_id(filename, &build_id, sizeof(build_id)) < 0) {

		pr_debug("Couldn't read a build-id in %s\n", filename);

		return -1;

	}



	build_id__sprintf(build_id, sizeof(build_id), sbuild_id);

	err = build_id_cache__add_s(sbuild_id, debugdir, filename, false);

	if (verbose)

		pr_info("Adding %s %s: %s\n", sbuild_id, filename,

			err ? "FAIL" : "Ok");

	return err;

}



static int build_id_cache__remove_file(const char *filename __used,

				       const char *debugdir __used)

{

	u8 build_id[BUILD_ID_SIZE];

	char sbuild_id[BUILD_ID_SIZE * 2 + 1];



	int err;



	if (filename__read_build_id(filename, &build_id, sizeof(build_id)) < 0) {

		pr_debug("Couldn't read a build-id in %s\n", filename);

		return -1;

	}



	build_id__sprintf(build_id, sizeof(build_id), sbuild_id);

	err = build_id_cache__remove_s(sbuild_id, debugdir);

	if (verbose)

		pr_info("Removing %s %s: %s\n", sbuild_id, filename,

			err ? "FAIL" : "Ok");



	return err;

}



static int __cmd_buildid_cache(void)

{

	struct strlist *list;

	struct str_node *pos;

	char debugdir[PATH_MAX];



	snprintf(debugdir, sizeof(debugdir), "%s/%s", getenv("HOME"),

		 DEBUG_CACHE_DIR);



	if (add_name_list_str) {

		list = strlist__new(true, add_name_list_str);

		if (list) {

			strlist__for_each(pos, list)

				if (build_id_cache__add_file(pos->s, debugdir)) {

					if (errno == EEXIST) {

						pr_debug("%s already in the cache\n",

							 pos->s);

						continue;

					}

					pr_warning("Couldn't add %s: %s\n",

						   pos->s, strerror(errno));

				}



			strlist__delete(list);

		}

	}



	if (remove_name_list_str) {

		list = strlist__new(true, remove_name_list_str);

		if (list) {

			strlist__for_each(pos, list)

				if (build_id_cache__remove_file(pos->s, debugdir)) {

					if (errno == ENOENT) {

						pr_debug("%s wasn't in the cache\n",

							 pos->s);

						continue;

					}

					pr_warning("Couldn't remove %s: %s\n",

						   pos->s, strerror(errno));

				}



			strlist__delete(list);

		}

	}



	return 0;

}



int cmd_buildid_cache(int argc, const char **argv, const char *prefix __used)

{

	argc = parse_options(argc, argv, buildid_cache_options,

			     buildid_cache_usage, 0);



	if (symbol__init() < 0)

		return -1;



	setup_pager();

	return __cmd_buildid_cache();

}

tools/perf/builtin.h

+1 −0
Original line number Diff line number Diff line
@@ -16,6 +16,7 @@ extern int check_pager_config(const char *cmd); 


extern int cmd_annotate(int argc, const char **argv, const char *prefix);

extern int cmd_bench(int argc, const char **argv, const char *prefix);

extern int cmd_buildid_cache(int argc, const char **argv, const char *prefix);

extern int cmd_buildid_list(int argc, const char **argv, const char *prefix);

extern int cmd_diff(int argc, const char **argv, const char *prefix);

extern int cmd_help(int argc, const char **argv, const char *prefix);

tools/perf/command-list.txt

+1 −0
Original line number Diff line number Diff line
@@ -5,6 +5,7 @@ 
perf-annotate			mainporcelain common

perf-archive			mainporcelain common

perf-bench			mainporcelain common

perf-buildid-cache		mainporcelain common

perf-buildid-list		mainporcelain common

perf-diff			mainporcelain common

perf-list			mainporcelain common