Commit ef100397 authored Aug 16, 2023 by Yu Kuai Committed by Jens Axboe Aug 30, 2023

blk-throttle: print signed value 'carryover_bytes/ios' for user



'carryover_bytes/ios' can be negative, indicate that some bio is
dispatched in advance within slice while configuration is updated.
Print a huge value is not user-friendly.

Signed-off-by: Yu Kuai <yukuai3@huawei.com>
Acked-by: Tejun Heo <tj@kernel.org>
Link: https://lore.kernel.org/r/20230816012708.1193747-2-yukuai1@huaweicloud.com


Signed-off-by: Jens Axboe <axboe@kernel.dk>

parent 6c1b980a

block/blk-throttle.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -816,7 +816,7 @@ static void tg_update_carryover(struct throtl_grp *tg)
		__tg_update_carryover(tg, WRITE);

		/* see comments in struct throtl_grp for meaning of these fields. */
		throtl_log(&tg->service_queue, "%s: %llu %llu %u %u\n", __func__,
		throtl_log(&tg->service_queue, "%s: %lld %lld %d %d\n", __func__,
		tg->carryover_bytes[READ], tg->carryover_bytes[WRITE],
		tg->carryover_ios[READ], tg->carryover_ios[WRITE]);
		}

block/blk-throttle.h

+2 −2

Original line number	Diff line number	Diff line
		@@ -127,8 +127,8 @@ struct throtl_grp {
		* bytes/ios are waited already in previous configuration, and they will
		* be used to calculate wait time under new configuration.
		*/
		uint64_t carryover_bytes[2];
		unsigned int carryover_ios[2];
		long long carryover_bytes[2];
		int carryover_ios[2];

		unsigned long last_check_time;