Commit ef0feca2 authored by Hans de Goede's avatar Hans de Goede Committed by Mauro Carvalho Chehab
Browse files

media: atomisp: Stop resetting selected input to 0 between /dev/video# opens 

No other V4L2 driver resets the selected input (front cam or back cam
selected in case of the atomisp).

Stop resetting selected input to 0 between /dev/video# opens.

This allows e.g. using v4l2-ctl -i to switch the input before starting
another app, which is useful since most apps don't support selecting
the input.

Note more in general the whole resetting of a bunch of internal
state from the open fop needs to be removed there to allow multiple
opens of /dev/video# for full v4l2 API compliance.

Link: https://lore.kernel.org/r/20230604161406.69369-2-hdegoede@redhat.com



Signed-off-by: default avatarHans de Goede <hdegoede@redhat.com>
Reviewed-by: default avatarAndy Shevchenko <andy.shevchenko@gmail.com>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@kernel.org>
parent 930d333a

drivers/staging/media/atomisp/pci/atomisp_fops.c

+0 −3
Original line number Original line Diff line number Diff line
@@ -474,9 +474,6 @@ static void atomisp_subdev_init_struct(struct atomisp_sub_device *asd) 
	/* s3a grid not enabled for any pipe */

	/* s3a grid not enabled for any pipe */

	asd->params.s3a_enabled_pipe = IA_CSS_PIPE_ID_NUM;

	asd->params.s3a_enabled_pipe = IA_CSS_PIPE_ID_NUM;





	/* Add for channel */

	asd->input_curr = 0;



	asd->copy_mode = false;

	asd->copy_mode = false;





	asd->stream_prepared = false;

	asd->stream_prepared = false;