Commit ef0fec22 authored by Dan Carpenter's avatar Dan Carpenter Committed by Greg Kroah-Hartman
Browse files

bus: fsl-mc: Fix test for end of loop 



The "desc" pointer can't possibly be NULL here.  If we can't find the
correct "desc" then tt points to the last element of the
fsl_mc_accepted_cmds[] array.  Fix this by testing if
"i == FSL_MC_NUM_ACCEPTED_CMDS" instead.

Fixes: 2cf1e703 ("bus: fsl-mc: add fsl-mc userspace support")
Acked-by: default avatarLaurentiu Tudor <laurentiu.tudor@nxp.com>
Signed-off-by: default avatarIoana Ciornei <ioana.ciornei@nxp.com>
Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Link: https://lore.kernel.org/r/20210208170949.3070898-2-ciorneiioana@gmail.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 609cf09c

drivers/bus/fsl-mc/fsl-mc-uapi.c

+1 −1
Original line number Diff line number Diff line
@@ -338,7 +338,7 @@ static int fsl_mc_command_check(struct fsl_mc_device *mc_dev, 
		if ((cmdid & desc->cmdid_mask) == desc->cmdid_value)

			break;

	}

	if (!desc) {

	if (i == FSL_MC_NUM_ACCEPTED_CMDS) {

		dev_err(&mc_dev->dev, "MC command 0x%04x: cmdid not accepted\n", cmdid);

		return -EACCES;

	}