Commit eeee4b77 authored by Eric Dumazet's avatar Eric Dumazet Committed by David S. Miller
Browse files

net: add more debug info in skb_checksum_help() 



This is a followup of previous patch.

Dumping the stack trace is a good start, but printing
basic skb information is probably better.

Signed-off-by: default avatarEric Dumazet <edumazet@google.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent d7ea0d9d

net/core/dev.c

+6 −4
Original line number Diff line number Diff line
@@ -3266,15 +3266,17 @@ int skb_checksum_help(struct sk_buff *skb) 


	offset = skb_checksum_start_offset(skb);

	ret = -EINVAL;

	if (WARN_ON_ONCE(offset >= skb_headlen(skb)))

	if (WARN_ON_ONCE(offset >= skb_headlen(skb))) {

		DO_ONCE_LITE(skb_dump, KERN_ERR, skb, false);

		goto out;



	}

	csum = skb_checksum(skb, offset, skb->len - offset, 0);



	offset += skb->csum_offset;

	if (WARN_ON_ONCE(offset + sizeof(__sum16) > skb_headlen(skb)))

	if (WARN_ON_ONCE(offset + sizeof(__sum16) > skb_headlen(skb))) {

		DO_ONCE_LITE(skb_dump, KERN_ERR, skb, false);

		goto out;



	}

	ret = skb_ensure_writable(skb, offset + sizeof(__sum16));

	if (ret)

		goto out;