Unverified Commit eed43b96 authored by Alexandru Ardelean's avatar Alexandru Ardelean Committed by Mark Brown
Browse files

regulator: devres: remove devm_regulator_bulk_unregister_supply_alias() 



This API hook isn't used anywhere and most-likely exists because of the
general principle of C APIs, where if an API function does an
allocation/registration, it must also have an equivalent
deallocation/deregistration counterpart.

For devm_ functions this isn't all that true (for all cases), as the idea
of these function is to provide an auto-cleanup logic on drivers/system
de-init.

Removing this also discourages any weird logic that could be created with
such an API function.

Signed-off-by: default avatarAlexandru Ardelean <aardelean@deviqon.com>
Link: https://lore.kernel.org/r/20210625122324.327585-4-aardelean@deviqon.com


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent 4ff75a29

drivers/regulator/devres.c

+0 −24
Original line number Diff line number Diff line
@@ -344,30 +344,6 @@ int devm_regulator_bulk_register_supply_alias(struct device *dev, 
}

EXPORT_SYMBOL_GPL(devm_regulator_bulk_register_supply_alias);



/**

 * devm_regulator_bulk_unregister_supply_alias - Managed unregister

 * multiple aliases

 *

 * @dev:    device to supply

 * @id:     list of supply names or regulator IDs

 * @num_id: number of aliases to unregister

 *

 * Unregister aliases registered with

 * devm_regulator_bulk_register_supply_alias(). Normally this function

 * will not need to be called and the resource management code

 * will ensure that the resource is freed.

 */

void devm_regulator_bulk_unregister_supply_alias(struct device *dev,

						 const char *const *id,

						 int num_id)

{

	int i;



	for (i = 0; i < num_id; ++i)

		devm_regulator_unregister_supply_alias(dev, id[i]);

}

EXPORT_SYMBOL_GPL(devm_regulator_bulk_unregister_supply_alias);



struct regulator_notifier_match {

	struct regulator *regulator;

	struct notifier_block *nb;

include/linux/regulator/consumer.h

+0 −8
Original line number Diff line number Diff line
@@ -230,9 +230,6 @@ int devm_regulator_bulk_register_supply_alias(struct device *dev, 
					      struct device *alias_dev,

					      const char *const *alias_id,

					      int num_id);

void devm_regulator_bulk_unregister_supply_alias(struct device *dev,

						 const char *const *id,

						 int num_id);



/* regulator output control and status */

int __must_check regulator_enable(struct regulator *regulator);
@@ -422,11 +419,6 @@ static inline int devm_regulator_bulk_register_supply_alias(struct device *dev, 
	return 0;

}



static inline void devm_regulator_bulk_unregister_supply_alias(

	struct device *dev, const char *const *id, int num_id)

{

}



static inline int regulator_enable(struct regulator *regulator)

{

	return 0;