Commit eeb0cfb6 authored by Chunfeng Yun's avatar Chunfeng Yun Committed by Greg Kroah-Hartman
Browse files

usb: gadget: tegra-xudc: fix the wrong mult value for HS isoc or intr 



usb_endpoint_maxp() only returns the bit[10:0] of wMaxPacketSize
of endpoint descriptor, not includes bit[12:11] anymore, so use
usb_endpoint_maxp_mult() instead.
Meanwhile no need AND 0x7ff when get maxp, remove it.

Fixes: 49db4272 ("usb: gadget: Add UDC driver for tegra XUSB device mode controller")
Cc: stable@vger.kernel.org
Acked-by: default avatarFelipe Balbi <balbi@kernel.org>
Signed-off-by: default avatarChunfeng Yun <chunfeng.yun@mediatek.com>
Link: https://lore.kernel.org/r/1628836253-7432-5-git-send-email-chunfeng.yun@mediatek.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent e9ab75f2

drivers/usb/gadget/udc/tegra-xudc.c

+2 −2
Original line number Diff line number Diff line
@@ -1610,7 +1610,7 @@ static void tegra_xudc_ep_context_setup(struct tegra_xudc_ep *ep) 
	u16 maxpacket, maxburst = 0, esit = 0;

	u32 val;



	maxpacket = usb_endpoint_maxp(desc) & 0x7ff;

	maxpacket = usb_endpoint_maxp(desc);

	if (xudc->gadget.speed == USB_SPEED_SUPER) {

		if (!usb_endpoint_xfer_control(desc))

			maxburst = comp_desc->bMaxBurst;
@@ -1621,7 +1621,7 @@ static void tegra_xudc_ep_context_setup(struct tegra_xudc_ep *ep) 
		   (usb_endpoint_xfer_int(desc) ||

		    usb_endpoint_xfer_isoc(desc))) {

		if (xudc->gadget.speed == USB_SPEED_HIGH) {

			maxburst = (usb_endpoint_maxp(desc) >> 11) & 0x3;

			maxburst = usb_endpoint_maxp_mult(desc) - 1;

			if (maxburst == 0x3) {

				dev_warn(xudc->dev,

					 "invalid endpoint maxburst\n");