Commit ee896466 authored by Andy Shevchenko's avatar Andy Shevchenko Committed by Greg Kroah-Hartman
Browse files

pps: clients: gpio: Get rid of legacy platform data 



Platform data is a legacy interface to supply device properties
to the driver. In this case we even don't have in-kernel users
for it. Just remove it for good.

Acked-by: default avatarRodolfo Giometti <giometti@enneenne.com>
Signed-off-by: default avatarAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Link: https://lore.kernel.org/r/20210318130321.24227-4-andriy.shevchenko@linux.intel.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent fde046a8

drivers/pps/clients/pps-gpio.c

+3 −14
Original line number Diff line number Diff line
@@ -16,7 +16,6 @@ 
#include <linux/platform_device.h>

#include <linux/slab.h>

#include <linux/pps_kernel.h>

#include <linux/pps-gpio.h>

#include <linux/gpio/consumer.h>

#include <linux/list.h>

#include <linux/of_device.h>
@@ -164,7 +163,6 @@ static int pps_gpio_probe(struct platform_device *pdev) 
	struct pps_gpio_device_data *data;

	int ret;

	int pps_default_params;

	const struct pps_gpio_platform_data *pdata = pdev->dev.platform_data;



	/* allocate space for device info */

	data = devm_kzalloc(&pdev->dev, sizeof(*data), GFP_KERNEL);
@@ -173,18 +171,9 @@ static int pps_gpio_probe(struct platform_device *pdev) 
	platform_set_drvdata(pdev, data);



	/* GPIO setup */

	if (pdata) {

		data->gpio_pin = pdata->gpio_pin;

		data->echo_pin = pdata->echo_pin;



		data->assert_falling_edge = pdata->assert_falling_edge;

		data->capture_clear = pdata->capture_clear;

		data->echo_active_ms = pdata->echo_active_ms;

	} else {

	ret = pps_gpio_setup(pdev);

	if (ret)

		return -EINVAL;

	}



	/* IRQ setup */

	ret = gpiod_to_irq(data->gpio_pin);

include/linux/pps-gpio.h

deleted100644 → 0
+0 −19
Original line number Diff line number Diff line 
/* SPDX-License-Identifier: GPL-2.0-or-later */

/*

 * pps-gpio.h -- PPS client for GPIOs

 *

 * Copyright (C) 2011 James Nuss <jamesnuss@nanometrics.ca>

 */



#ifndef _PPS_GPIO_H

#define _PPS_GPIO_H



struct pps_gpio_platform_data {

	struct gpio_desc *gpio_pin;

	struct gpio_desc *echo_pin;

	bool assert_falling_edge;

	bool capture_clear;

	unsigned int echo_active_ms;

};



#endif /* _PPS_GPIO_H */