Commit ee84a303 authored by Ian Rogers's avatar Ian Rogers Committed by Arnaldo Carvalho de Melo
Browse files

perf thread: Add accessor functions for thread 



Using accessors will make it easier to add reference count checking in
later patches.

Committer notes:

thread->nsinfo wasn't wrapped as it is used together with
nsinfo__zput(), where does a trick to set the field with a refcount
being dropped to NULL, and that doesn't work well with using
thread__nsinfo(thread), that loses the &thread->nsinfo pointer.

When refcount checking is added to 'struct thread', later in this
series, nsinfo__zput(RC_CHK_ACCESS(thread)->nsinfo) will be used to
check the thread pointer.

Signed-off-by: default avatarIan Rogers <irogers@google.com>
Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Ali Saidi <alisaidi@amazon.com>
Cc: Andi Kleen <ak@linux.intel.com>
Cc: Athira Rajeev <atrajeev@linux.vnet.ibm.com>
Cc: Brian Robbins <brianrob@linux.microsoft.com>
Cc: Changbin Du <changbin.du@huawei.com>
Cc: Dmitrii Dolgov <9erthalion6@gmail.com>
Cc: Fangrui Song <maskray@google.com>
Cc: German Gomez <german.gomez@arm.com>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Ivan Babrou <ivan@cloudflare.com>
Cc: James Clark <james.clark@arm.com>
Cc: Jing Zhang <renyu.zj@linux.alibaba.com>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: John Garry <john.g.garry@oracle.com>
Cc: K Prateek Nayak <kprateek.nayak@amd.com>
Cc: Kan Liang <kan.liang@linux.intel.com>
Cc: Leo Yan <leo.yan@linaro.org>
Cc: Liam Howlett <liam.howlett@oracle.com>
Cc: Mark Rutland <mark.rutland@arm.com>
Cc: Miguel Ojeda <ojeda@kernel.org>
Cc: Mike Leach <mike.leach@linaro.org>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Naveen N. Rao <naveen.n.rao@linux.vnet.ibm.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Ravi Bangoria <ravi.bangoria@amd.com>
Cc: Sean Christopherson <seanjc@google.com>
Cc: Steinar H. Gunderson <sesse@google.com>
Cc: Suzuki Poulouse <suzuki.poulose@arm.com>
Cc: Wenyu Liu <liuwenyu7@huawei.com>
Cc: Will Deacon <will@kernel.org>
Cc: Yang Jihong <yangjihong1@huawei.com>
Cc: Ye Xingchen <ye.xingchen@zte.com.cn>
Cc: Yuan Can <yuancan@huawei.com>
Cc: coresight@lists.linaro.org
Cc: linux-arm-kernel@lists.infradead.org
Link: https://lore.kernel.org/r/20230608232823.4027869-4-irogers@google.com


Signed-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
parent 7ee227f6

tools/perf/arch/arm/tests/dwarf-unwind.c

+1 −1
Original line number Diff line number Diff line
@@ -26,7 +26,7 @@ static int sample_ustack(struct perf_sample *sample, 


	sp = (unsigned long) regs[PERF_REG_ARM_SP];



	map = maps__find(thread->maps, (u64)sp);

	map = maps__find(thread__maps(thread), (u64)sp);

	if (!map) {

		pr_debug("failed to get stack map\n");

		free(buf);

tools/perf/arch/arm64/tests/dwarf-unwind.c

+1 −1
Original line number Diff line number Diff line
@@ -26,7 +26,7 @@ static int sample_ustack(struct perf_sample *sample, 


	sp = (unsigned long) regs[PERF_REG_ARM64_SP];



	map = maps__find(thread->maps, (u64)sp);

	map = maps__find(thread__maps(thread), (u64)sp);

	if (!map) {

		pr_debug("failed to get stack map\n");

		free(buf);

tools/perf/arch/powerpc/tests/dwarf-unwind.c

+1 −1
Original line number Diff line number Diff line
@@ -26,7 +26,7 @@ static int sample_ustack(struct perf_sample *sample, 


	sp = (unsigned long) regs[PERF_REG_POWERPC_R1];



	map = maps__find(thread->maps, (u64)sp);

	map = maps__find(thread__maps(thread), (u64)sp);

	if (!map) {

		pr_debug("failed to get stack map\n");

		free(buf);

tools/perf/arch/x86/tests/dwarf-unwind.c

+1 −1
Original line number Diff line number Diff line
@@ -26,7 +26,7 @@ static int sample_ustack(struct perf_sample *sample, 


	sp = (unsigned long) regs[PERF_REG_X86_SP];



	map = maps__find(thread->maps, (u64)sp);

	map = maps__find(thread__maps(thread), (u64)sp);

	if (!map) {

		pr_debug("failed to get stack map\n");

		free(buf);

tools/perf/builtin-c2c.c

+3 −3
Original line number Diff line number Diff line
@@ -293,7 +293,7 @@ static int process_sample_event(struct perf_tool *tool __maybe_unused, 
	}



	if (c2c.stitch_lbr)

		al.thread->lbr_stitch_enable = true;

		thread__set_lbr_stitch_enable(al.thread, true);



	ret = sample__resolve_callchain(sample, &callchain_cursor, NULL,

					evsel, &al, sysctl_perf_event_max_stack);
@@ -1149,14 +1149,14 @@ pid_entry(struct perf_hpp_fmt *fmt, struct perf_hpp *hpp, 
{

	int width = c2c_width(fmt, hpp, he->hists);



	return scnprintf(hpp->buf, hpp->size, "%*d", width, he->thread->pid_);

	return scnprintf(hpp->buf, hpp->size, "%*d", width, thread__pid(he->thread));

}



static int64_t

pid_cmp(struct perf_hpp_fmt *fmt __maybe_unused,

	struct hist_entry *left, struct hist_entry *right)

{

	return left->thread->pid_ - right->thread->pid_;

	return thread__pid(left->thread) - thread__pid(right->thread);

}



static int64_t