Commit ee2a095d authored by Xiubo Li's avatar Xiubo Li Committed by Ilya Dryomov
Browse files

ceph: initialize pathlen variable in reconnect_caps_cb 



The smatch static checker warned about an uninitialized symbol usage in
this function, in the case where ceph_mdsc_build_path returns an error.

It turns out that that case is harmless, but it just looks sketchy.
Initialize the variable at declaration time, and remove the unneeded
setting of it later.

Fixes: a33f6432 ("ceph: encode inodes' parent/d_name in cap reconnect message")
Reported-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: default avatarXiubo Li <xiubli@redhat.com>
Reviewed-by: default avatarJeff Layton <jlayton@kernel.org>
Signed-off-by: default avatarIlya Dryomov <idryomov@gmail.com>
parent e485d028

fs/ceph/mds_client.c

+1 −2
Original line number Diff line number Diff line
@@ -3683,7 +3683,7 @@ static int reconnect_caps_cb(struct inode *inode, struct ceph_cap *cap, 
	struct ceph_pagelist *pagelist = recon_state->pagelist;

	struct dentry *dentry;

	char *path;

	int pathlen, err;

	int pathlen = 0, err;

	u64 pathbase;

	u64 snap_follows;
@@ -3703,7 +3703,6 @@ static int reconnect_caps_cb(struct inode *inode, struct ceph_cap *cap, 
		}

	} else {

		path = NULL;

		pathlen = 0;

		pathbase = 0;

	}