Commit edfb8ebc authored Nov 10, 2015 by Andreas Gruenbacher Committed by Dave Chinner Nov 10, 2015

xfs: Fix error path in xfs_get_acl



Error codes from xfs_attr_get other than -ENOATTR were not properly
reported.  Fix that.

In addition, the declaration of struct xfs_inode in xfs_acl.h isn't needed.

Signed-off-by: Andreas Gruenbacher <agruenba@redhat.com>
Reviewed-by: Dave Chinner <dchinner@redhat.com>
Signed-off-by: Dave Chinner <david@fromorbit.com>

parent fc0561ce

fs/xfs/xfs_acl.c

+1 −0

Original line number	Original line	Diff line number	Diff line
	@@ -163,6 +163,7 @@ xfs_get_acl(struct inode *inode, int type)
	*/		*/
	if (error == -ENOATTR)		if (error == -ENOATTR)
	goto out_update_cache;		goto out_update_cache;
			acl = ERR_PTR(error);
	goto out;		goto out;
	}		}

fs/xfs/xfs_acl.h

+0 −1

Original line number	Original line	Diff line number	Diff line
	@@ -20,7 +20,6 @@

	struct inode;		struct inode;
	struct posix_acl;		struct posix_acl;
	struct xfs_inode;

	#ifdef CONFIG_XFS_POSIX_ACL		#ifdef CONFIG_XFS_POSIX_ACL
	extern struct posix_acl xfs_get_acl(struct inode inode, int type);		extern struct posix_acl xfs_get_acl(struct inode inode, int type);