Commit ede13285 authored by Denis Efremov's avatar Denis Efremov Committed by Herbert Xu
Browse files

crypto: sun8i-ss - use kfree_sensitive() 



Use kfree_sensitive() instead of open-coding it.

Signed-off-by: default avatarDenis Efremov <efremov@linux.com>
Acked-by: default avatarCorentin Labbe <clabbe.montjoie@gmail.com>
Tested-by: default avatarCorentin Labbe <clabbe.montjoie@gmail.com>
Signed-off-by: default avatarHerbert Xu <herbert@gondor.apana.org.au>
parent 712d8069

drivers/crypto/allwinner/sun8i-ss/sun8i-ss-cipher.c

+3 −12
Original line number Diff line number Diff line
@@ -368,10 +368,7 @@ void sun8i_ss_cipher_exit(struct crypto_tfm *tfm) 
{

	struct sun8i_cipher_tfm_ctx *op = crypto_tfm_ctx(tfm);



	if (op->key) {

		memzero_explicit(op->key, op->keylen);

		kfree(op->key);

	}

	kfree_sensitive(op->key);

	crypto_free_skcipher(op->fallback_tfm);

	pm_runtime_put_sync(op->ss->dev);

}
@@ -393,10 +390,7 @@ int sun8i_ss_aes_setkey(struct crypto_skcipher *tfm, const u8 *key, 
		dev_dbg(ss->dev, "ERROR: Invalid keylen %u\n", keylen);

		return -EINVAL;

	}

	if (op->key) {

		memzero_explicit(op->key, op->keylen);

		kfree(op->key);

	}

	kfree_sensitive(op->key);

	op->keylen = keylen;

	op->key = kmemdup(key, keylen, GFP_KERNEL | GFP_DMA);

	if (!op->key)
@@ -419,10 +413,7 @@ int sun8i_ss_des3_setkey(struct crypto_skcipher *tfm, const u8 *key, 
		return -EINVAL;

	}



	if (op->key) {

		memzero_explicit(op->key, op->keylen);

		kfree(op->key);

	}

	kfree_sensitive(op->key);

	op->keylen = keylen;

	op->key = kmemdup(key, keylen, GFP_KERNEL | GFP_DMA);

	if (!op->key)