Commit ed96824b authored by Yuanjun Gong's avatar Yuanjun Gong Committed by Jakub Kicinski
Browse files

atheros: fix return value check in atl1_tso() 



in atl1_tso(), it should check the return value of pskb_trim(),
and return an error code if an unexpected value is returned
by pskb_trim().

Fixes: 401c0aab ("atl1: simplify tx packet descriptor")
Signed-off-by: default avatarYuanjun Gong <ruc_gongyuanjun@163.com>
Link: https://lore.kernel.org/r/20230722142511.12448-1-ruc_gongyuanjun@163.com


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 22117b3a

drivers/net/ethernet/atheros/atlx/atl1.c

+5 −2
Original line number Diff line number Diff line
@@ -2113,8 +2113,11 @@ static int atl1_tso(struct atl1_adapter *adapter, struct sk_buff *skb, 


			real_len = (((unsigned char *)iph - skb->data) +

				ntohs(iph->tot_len));

			if (real_len < skb->len)

				pskb_trim(skb, real_len);

			if (real_len < skb->len) {

				err = pskb_trim(skb, real_len);

				if (err)

					return err;

			}

			hdr_len = skb_tcp_all_headers(skb);

			if (skb->len == hdr_len) {

				iph->check = 0;