Commit ed4a854b authored by Keith Busch's avatar Keith Busch Committed by Christoph Hellwig
Browse files

nvme: warn of unhandled effects only once 



We don't need to repeatedly spam the kernel logs with the same warning
about unhandled passthrough IO effects. Just one warning is sufficient
to observe this condition occurs.

Signed-off-by: default avatarKeith Busch <kbusch@kernel.org>
Reviewed-by: default avatarChaitanya Kulkarni <chaitanya.kulkarni@wdc.com>
Signed-off-by: default avatarChristoph Hellwig <hch@lst.de>
parent f4b9e6c9

drivers/nvme/host/core.c

+3 −3
Original line number Diff line number Diff line
@@ -1072,7 +1072,7 @@ u32 nvme_command_effects(struct nvme_ctrl *ctrl, struct nvme_ns *ns, u8 opcode) 
		if (ns->head->effects)

			effects = le32_to_cpu(ns->head->effects->iocs[opcode]);

		if (effects & ~(NVME_CMD_EFFECTS_CSUPP | NVME_CMD_EFFECTS_LBCC))

			dev_warn(ctrl->device,

			dev_warn_once(ctrl->device,

				"IO command:%02x has unhandled effects:%08x\n",

				opcode, effects);

		return 0;