Commit ed2133b7 authored by Mauro Carvalho Chehab's avatar Mauro Carvalho Chehab Committed by Jonathan Corbet
Browse files

scripts: sphinx-pre-install: report broken venv 



After distro upgrades, the directory names for python may change.
On such case, the previously-created venv will be broken, and
sphinx-build won't run.

Add a logic to report it.

Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@kernel.org>
Link: https://lore.kernel.org/r/f117f03555b0636d2be0b68f3a23b1d3f03ccf1d.1656756450.git.mchehab@kernel.org


[jc: fixed typo in warning message]
Signed-off-by: default avatarJonathan Corbet <corbet@lwn.net>
parent 7c2d45a3

scripts/sphinx-pre-install

+6 −0
Original line number Diff line number Diff line
@@ -720,6 +720,12 @@ sub get_virtenv() 
		next if (! -f $sphinx_cmd);



		my $ver = get_sphinx_version($sphinx_cmd);



		if (!$ver) {

			$f =~ s#/bin/activate##;

			print("Warning: virtual environment $f is not working.\nPython version upgrade? Remove it with:\n\n\trm -rf $f\n\n");

		}



		if ($need_sphinx && ($ver ge $min_version)) {

			return ($f, $ver);

		} elsif ($ver gt $cur_version) {