Commit ed14e590 authored by Zhengchao Shao's avatar Zhengchao Shao Committed by Jakub Kicinski
Browse files

net: thunderbolt: fix memory leak in tbnet_open() 



When tb_ring_alloc_rx() failed in tbnet_open(), ida that allocated in
tb_xdomain_alloc_out_hopid() is not released. Add
tb_xdomain_release_out_hopid() to the error path to release ida.

Fixes: 180b0689 ("thunderbolt: Allow multiple DMA tunnels over a single XDomain connection")
Signed-off-by: default avatarZhengchao Shao <shaozhengchao@huawei.com>
Acked-by: default avatarMika Westerberg <mika.westerberg@linux.intel.com>
Reviewed-by: default avatarJiri Pirko <jiri@nvidia.com>
Link: https://lore.kernel.org/r/20221207015001.1755826-1-shaozhengchao@huawei.com


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 803e8486

drivers/net/thunderbolt.c

+1 −0
Original line number Diff line number Diff line
@@ -914,6 +914,7 @@ static int tbnet_open(struct net_device *dev) 
				eof_mask, tbnet_start_poll, net);

	if (!ring) {

		netdev_err(dev, "failed to allocate Rx ring\n");

		tb_xdomain_release_out_hopid(xd, hopid);

		tb_ring_free(net->tx_ring.ring);

		net->tx_ring.ring = NULL;

		return -ENOMEM;