Commit ed0cf84e authored by Ani Sinha's avatar Ani Sinha Committed by Wei Liu
Browse files

vmbus_testing: fix wrong python syntax for integer value comparison 



It is incorrect in python to compare integer values using the "is" keyword.
The "is" keyword in python is used to compare references to two objects,
not their values. Newer version of python3 (version 3.8) throws a warning
when such incorrect comparison is made. For value comparison, "==" should
be used.

Fix this in the code and suppress the following warning:

/usr/sbin/vmbus_testing:167: SyntaxWarning: "is" with a literal. Did you mean "=="?

Signed-off-by: default avatarAni Sinha <anisinha@redhat.com>
Link: https://lore.kernel.org/r/20230705134408.6302-1-anisinha@redhat.com


Signed-off-by: default avatarWei Liu <wei.liu@kernel.org>
parent 060f2b97

tools/hv/vmbus_testing

+2 −2
Original line number Diff line number Diff line
@@ -164,7 +164,7 @@ def recursive_file_lookup(path, file_map): 
def get_all_devices_test_status(file_map):



        for device in file_map:

                if (get_test_state(locate_state(device, file_map)) is 1):

                if (get_test_state(locate_state(device, file_map)) == 1):

                        print("Testing = ON for: {}"

                              .format(device.split("/")[5]))

                else:
@@ -203,7 +203,7 @@ def write_test_files(path, value): 
def set_test_state(state_path, state_value, quiet):



        write_test_files(state_path, state_value)

        if (get_test_state(state_path) is 1):

        if (get_test_state(state_path) == 1):

                if (not quiet):

                        print("Testing = ON for device: {}"

                              .format(state_path.split("/")[5]))