Commit ecc2f396 authored by Pali Rohár's avatar Pali Rohár Committed by Ulf Hansson
Browse files

mmc: sdio: Move SDIO IDs from ath6kl driver to common include file 



Also replace generic MANUFACTURER macros by proper SDIO IDs macros.

Check for "AR6003 or later" is slightly modified to use SDIO device IDs.
This allows removal of all custom MANUFACTURER macros from ath6kl.

Signed-off-by: default avatarPali Rohár <pali@kernel.org>
Acked-by: default avatarKalle Valo <kvalo@codeaurora.org>
Link: https://lore.kernel.org/r/20200522144412.19712-8-pali@kernel.org


Signed-off-by: default avatarUlf Hansson <ulf.hansson@linaro.org>
parent b8c26a96

drivers/net/wireless/ath/ath6kl/hif.h

+0 −6
Original line number Diff line number Diff line
@@ -35,12 +35,6 @@ 
#define MAX_SCATTER_ENTRIES_PER_REQ      16

#define MAX_SCATTER_REQ_TRANSFER_SIZE    (32 * 1024)



#define MANUFACTURER_ID_AR6003_BASE        0x300

#define MANUFACTURER_ID_AR6004_BASE        0x400

    /* SDIO manufacturer ID and Codes */

#define MANUFACTURER_ID_ATH6KL_BASE_MASK     0xFF00

#define MANUFACTURER_CODE                  0x271	/* Atheros */



/* Mailbox address in SDIO address space */

#define HIF_MBOX_BASE_ADDR                 0x800

#define HIF_MBOX_WIDTH                     0x800

drivers/net/wireless/ath/ath6kl/sdio.c

+8 −9
Original line number Diff line number Diff line
@@ -799,8 +799,7 @@ static int ath6kl_sdio_config(struct ath6kl *ar) 


	sdio_claim_host(func);



	if ((ar_sdio->id->device & MANUFACTURER_ID_ATH6KL_BASE_MASK) >=

	    MANUFACTURER_ID_AR6003_BASE) {

	if (ar_sdio->id->device >= SDIO_DEVICE_ID_ATHEROS_AR6003_00) {

		/* enable 4-bit ASYNC interrupt on AR6003 or later */

		ret = ath6kl_sdio_func0_cmd52_wr_byte(func->card,

						CCCR_SDIO_IRQ_MODE_REG,
@@ -1409,13 +1408,13 @@ static void ath6kl_sdio_remove(struct sdio_func *func) 
}



static const struct sdio_device_id ath6kl_sdio_devices[] = {

	{SDIO_DEVICE(MANUFACTURER_CODE, (MANUFACTURER_ID_AR6003_BASE | 0x0))},

	{SDIO_DEVICE(MANUFACTURER_CODE, (MANUFACTURER_ID_AR6003_BASE | 0x1))},

	{SDIO_DEVICE(MANUFACTURER_CODE, (MANUFACTURER_ID_AR6004_BASE | 0x0))},

	{SDIO_DEVICE(MANUFACTURER_CODE, (MANUFACTURER_ID_AR6004_BASE | 0x1))},

	{SDIO_DEVICE(MANUFACTURER_CODE, (MANUFACTURER_ID_AR6004_BASE | 0x2))},

	{SDIO_DEVICE(MANUFACTURER_CODE, (MANUFACTURER_ID_AR6004_BASE | 0x18))},

	{SDIO_DEVICE(MANUFACTURER_CODE, (MANUFACTURER_ID_AR6004_BASE | 0x19))},

	{SDIO_DEVICE(SDIO_VENDOR_ID_ATHEROS, SDIO_DEVICE_ID_ATHEROS_AR6003_00)},

	{SDIO_DEVICE(SDIO_VENDOR_ID_ATHEROS, SDIO_DEVICE_ID_ATHEROS_AR6003_01)},

	{SDIO_DEVICE(SDIO_VENDOR_ID_ATHEROS, SDIO_DEVICE_ID_ATHEROS_AR6004_00)},

	{SDIO_DEVICE(SDIO_VENDOR_ID_ATHEROS, SDIO_DEVICE_ID_ATHEROS_AR6004_01)},

	{SDIO_DEVICE(SDIO_VENDOR_ID_ATHEROS, SDIO_DEVICE_ID_ATHEROS_AR6004_02)},

	{SDIO_DEVICE(SDIO_VENDOR_ID_ATHEROS, SDIO_DEVICE_ID_ATHEROS_AR6004_18)},

	{SDIO_DEVICE(SDIO_VENDOR_ID_ATHEROS, SDIO_DEVICE_ID_ATHEROS_AR6004_19)},

	{},

};

include/linux/mmc/sdio_ids.h

+10 −0
Original line number Diff line number Diff line
@@ -24,6 +24,16 @@ 
/*

 * Vendors and devices.  Sort key: vendor first, device next.

 */



#define SDIO_VENDOR_ID_ATHEROS			0x0271

#define SDIO_DEVICE_ID_ATHEROS_AR6003_00	0x0300

#define SDIO_DEVICE_ID_ATHEROS_AR6003_01	0x0301

#define SDIO_DEVICE_ID_ATHEROS_AR6004_00	0x0400

#define SDIO_DEVICE_ID_ATHEROS_AR6004_01	0x0401

#define SDIO_DEVICE_ID_ATHEROS_AR6004_02	0x0402

#define SDIO_DEVICE_ID_ATHEROS_AR6004_18	0x0418

#define SDIO_DEVICE_ID_ATHEROS_AR6004_19	0x0419



#define SDIO_VENDOR_ID_BROADCOM			0x02d0

#define SDIO_DEVICE_ID_BROADCOM_43143		0xa887

#define SDIO_DEVICE_ID_BROADCOM_43241		0x4324