Commit ecbb4dac authored by Greg Kroah-Hartman's avatar Greg Kroah-Hartman
Browse files

USB: host: isp1362: delete isp1362_show_regs() 



No one is calling this function, so it's pointless to keep around as it
is triggering automated scanning tools to try to fix up the problems
with it using in_interrupt().

So delete the thing.

Reported-by: default avatarThomas Gleixner <tglx@linutronix.de>
Reported-by: default avatarSebastian Andrzej Siewior <bigeasy@linutronix.de>
Reported-by: default avatarAhmed S. Darwish <a.darwish@linutronix.de>
Reviewed-by: default avatarSebastian Andrzej Siewior <bigeasy@linutronix.de>
Link: https://lore.kernel.org/r/20201028113107.2007742-1-gregkh@linuxfoundation.org


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 5ed132db

drivers/usb/host/isp1362.h

+0 −54
Original line number Diff line number Diff line
@@ -793,60 +793,6 @@ static void isp1362_write_fifo(struct isp1362_hcd *isp1362_hcd, void *buf, u16 l 
			ISP1362_REG_NO(ISP1362_REG_##r), isp1362_read_reg16(d, r));	\

}



static void __attribute__((__unused__)) isp1362_show_regs(struct isp1362_hcd *isp1362_hcd)

{

	isp1362_show_reg(isp1362_hcd, HCREVISION);

	isp1362_show_reg(isp1362_hcd, HCCONTROL);

	isp1362_show_reg(isp1362_hcd, HCCMDSTAT);

	isp1362_show_reg(isp1362_hcd, HCINTSTAT);

	isp1362_show_reg(isp1362_hcd, HCINTENB);

	isp1362_show_reg(isp1362_hcd, HCFMINTVL);

	isp1362_show_reg(isp1362_hcd, HCFMREM);

	isp1362_show_reg(isp1362_hcd, HCFMNUM);

	isp1362_show_reg(isp1362_hcd, HCLSTHRESH);

	isp1362_show_reg(isp1362_hcd, HCRHDESCA);

	isp1362_show_reg(isp1362_hcd, HCRHDESCB);

	isp1362_show_reg(isp1362_hcd, HCRHSTATUS);

	isp1362_show_reg(isp1362_hcd, HCRHPORT1);

	isp1362_show_reg(isp1362_hcd, HCRHPORT2);



	isp1362_show_reg(isp1362_hcd, HCHWCFG);

	isp1362_show_reg(isp1362_hcd, HCDMACFG);

	isp1362_show_reg(isp1362_hcd, HCXFERCTR);

	isp1362_show_reg(isp1362_hcd, HCuPINT);



	if (in_interrupt())

		DBG(0, "%-12s[%02x]:     %04x\n", "HCuPINTENB",

			 ISP1362_REG_NO(ISP1362_REG_HCuPINTENB), isp1362_hcd->irqenb);

	else

		isp1362_show_reg(isp1362_hcd, HCuPINTENB);

	isp1362_show_reg(isp1362_hcd, HCCHIPID);

	isp1362_show_reg(isp1362_hcd, HCSCRATCH);

	isp1362_show_reg(isp1362_hcd, HCBUFSTAT);

	isp1362_show_reg(isp1362_hcd, HCDIRADDR);

	/* Access would advance fifo

	 * isp1362_show_reg(isp1362_hcd, HCDIRDATA);

	 */

	isp1362_show_reg(isp1362_hcd, HCISTLBUFSZ);

	isp1362_show_reg(isp1362_hcd, HCISTLRATE);

	isp1362_show_reg(isp1362_hcd, HCINTLBUFSZ);

	isp1362_show_reg(isp1362_hcd, HCINTLBLKSZ);

	isp1362_show_reg(isp1362_hcd, HCINTLDONE);

	isp1362_show_reg(isp1362_hcd, HCINTLSKIP);

	isp1362_show_reg(isp1362_hcd, HCINTLLAST);

	isp1362_show_reg(isp1362_hcd, HCINTLCURR);

	isp1362_show_reg(isp1362_hcd, HCATLBUFSZ);

	isp1362_show_reg(isp1362_hcd, HCATLBLKSZ);

	/* only valid after ATL_DONE interrupt

	 * isp1362_show_reg(isp1362_hcd, HCATLDONE);

	 */

	isp1362_show_reg(isp1362_hcd, HCATLSKIP);

	isp1362_show_reg(isp1362_hcd, HCATLLAST);

	isp1362_show_reg(isp1362_hcd, HCATLCURR);

	isp1362_show_reg(isp1362_hcd, HCATLDTC);

	isp1362_show_reg(isp1362_hcd, HCATLDTCTO);

}



static void isp1362_write_diraddr(struct isp1362_hcd *isp1362_hcd, u16 offset, u16 len)

{

	len = (len + 1) & ~1;