Commit ec8f32ad authored by Leon Romanovsky's avatar Leon Romanovsky Committed by Steffen Klassert
Browse files

xfrm: Fix leak of dev tracker 



At the stage of direction checks, the netdev reference tracker is
already initialized, but released with wrong *_put() call.

Fixes: 919e43fa ("xfrm: add an interface to offload policy")
Signed-off-by: default avatarLeon Romanovsky <leonro@nvidia.com>
Reviewed-by: default avatarSimon Horman <simon.horman@corigine.com>
Reviewed-by: default avatarEric Dumazet <edumazet@google.com>
Signed-off-by: default avatarSteffen Klassert <steffen.klassert@secunet.com>
parent 94b95dfa

net/xfrm/xfrm_device.c

+1 −1
Original line number Diff line number Diff line
@@ -378,7 +378,7 @@ int xfrm_dev_policy_add(struct net *net, struct xfrm_policy *xp, 
		break;

	default:

		xdo->dev = NULL;

		dev_put(dev);

		netdev_put(dev, &xdo->dev_tracker);

		NL_SET_ERR_MSG(extack, "Unrecognized offload direction");

		return -EINVAL;

	}